Opened 15 years ago

Last modified 14 years ago

#36 closed Bug

bug in FCKTools.GetParentWindow — at Version 1

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: FCKeditor 2.4
Component: General Version:
Keywords: Cc:

Description (last modified by Alfonso Martínez de Lizarrondo)

I've run the automated test (first I've had to patch the test files adding a

FCKScriptLoader._FCKeditorPath = document.location.pathname.substring(0,document.location.pathname.lastIndexOf('_test')) ;

so it does work in any directory) and then I've found that Firefox had an error in FCKTools.GetParentWindow I've looked at it and I think that it was wrong because it tries to use document.contentWindow but contentWindow is a property of an iframe, it doesn't point to the parent window of the document in any browser. Instead I've changed to

FCKTools.GetParentWindow = function( document )
{
	return document.parentWindow ? document.parentWindow : document.defaultView ;
}

That should work in IE, Firefox and Opera.

All of these changes are in my development branch

Change History (1)

comment:1 Changed 15 years ago by Alfonso Martínez de Lizarrondo

Description: modified (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2021 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy