Opened 10 years ago

Closed 10 years ago

#3725 closed Bug (fixed)

Same uiColor accross editors' floatpanels

Reported by: Tobiasz Cudnik Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

  1. Open ui_color.html sample
  2. Invoke context menu in second editor
  3. Invoke context menu in first editor
    • It has color from second editor
    • It should have color from first one

Attachments (3)

3725.patch (935 bytes) - added by Tobiasz Cudnik 10 years ago.
3725_2.patch (554 bytes) - added by Tobiasz Cudnik 10 years ago.
3725_3.patch (804 bytes) - added by Frederico Caldeira Knabben 10 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 10 years ago by Tobiasz Cudnik

Milestone: CKEditor 3.0
Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 10 years ago by Tobiasz Cudnik

Attachment: 3725.patch added

comment:2 Changed 10 years ago by Tobiasz Cudnik

Keywords: Review? added

Floatpanel has been reused in several editors with same skin/parent. Now each editor has separate float panel.

comment:3 in reply to:  2 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Replying to tobiasz.cudnik:

Floatpanel has been reused in several editors with same skin/parent. Now each editor has separate float panel.

This is actually a performance feature, so it's wrong to simply remove it.

As we can see, each panel has a string identifying it. This string aims to identify things that can make panels different, like having different CSSs. What's missing there is adding the uiColor in that string, as this is also one of the key features for panels.

Other than that, the _source/plugins/panel/plugin.js file contains an undesired change.

Changed 10 years ago by Tobiasz Cudnik

Attachment: 3725_2.patch added

comment:4 Changed 10 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
Owner: changed from Tobiasz Cudnik to Frederico Caldeira Knabben
Status: assignednew

For uniformity (and shortnesses), we should simply use the syntax used at line 24.

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 3725_3.patch added

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed
Status: newassigned

comment:7 Changed 10 years ago by Tobiasz Cudnik

Keywords: Review+ added; Review? removed

comment:8 Changed 10 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [3680].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy