Opened 15 years ago
Closed 15 years ago
#3725 closed Bug (fixed)
Same uiColor accross editors' floatpanels
Reported by: | Tobiasz Cudnik | Owned by: | Frederico Caldeira Knabben |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | General | Version: | |
Keywords: | Confirmed Review+ | Cc: |
Description
- Open ui_color.html sample
- Invoke context menu in second editor
- Invoke context menu in first editor
- It has color from second editor
- It should have color from first one
Attachments (3)
Change History (11)
comment:1 Changed 15 years ago by
Milestone: | → CKEditor 3.0 |
---|---|
Owner: | set to Tobiasz Cudnik |
Status: | new → assigned |
Changed 15 years ago by
Attachment: | 3725.patch added |
---|
comment:2 follow-up: 3 Changed 15 years ago by
Keywords: | Review? added |
---|
comment:3 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
Replying to tobiasz.cudnik:
Floatpanel has been reused in several editors with same skin/parent. Now each editor has separate float panel.
This is actually a performance feature, so it's wrong to simply remove it.
As we can see, each panel has a string identifying it. This string aims to identify things that can make panels different, like having different CSSs. What's missing there is adding the uiColor in that string, as this is also one of the key features for panels.
Other than that, the _source/plugins/panel/plugin.js file contains an undesired change.
Changed 15 years ago by
Attachment: | 3725_2.patch added |
---|
comment:4 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
comment:5 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|---|
Owner: | changed from Tobiasz Cudnik to Frederico Caldeira Knabben |
Status: | assigned → new |
For uniformity (and shortnesses), we should simply use the syntax used at line 24.
Changed 15 years ago by
Attachment: | 3725_3.patch added |
---|
comment:6 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|---|
Status: | new → assigned |
comment:7 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
Floatpanel has been reused in several editors with same skin/parent. Now each editor has separate float panel.