Ticket #3764 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Show Blocks + setData causes blocks refresh problem

Reported by: damo Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: IBM Confirmed Review+ Cc:

Description

When setData is called on the editor while show blocks is enabled, the block indicators are not refreshed properly.

Attached example test.

To reproduce:

  1. Open attached sample
  2. When editor ready, press Set Data.
  3. Enable Show Blocks
  4. Change the text in the edit area and press Set Data again

Results:
Show Blocks is still active on toolbar but block indicators are no longer rendered properly.

Attachments

blocksSample.html (1.3 KB) - added by damo 5 years ago.
3764.patch (865 bytes) - added by tobiasz.cudnik 5 years ago.
3764_2.patch (854 bytes) - added by tobiasz.cudnik 5 years ago.

Change History

Changed 5 years ago by damo

comment:1 Changed 5 years ago by tobiasz.cudnik

  • Keywords Confirmed added
  • Owner set to tobiasz.cudnik
  • Status changed from new to assigned

Changed 5 years ago by tobiasz.cudnik

comment:2 Changed 5 years ago by tobiasz.cudnik

  • Keywords Review? added

Patch handles also new page command.

comment:3 Changed 5 years ago by fredck

  • Keywords Review- added; Review? removed

It looks like we don't need the on('mode') code anymore at this point.

Also, please preserve the code style. It's just a matter of maintaining the style we can see in the statements a few lines above the patch changes.

Changed 5 years ago by tobiasz.cudnik

comment:4 Changed 5 years ago by tobiasz.cudnik

  • Keywords Review? added; Review- removed

comment:5 Changed 5 years ago by garry.yao

  • Keywords Review+ added; Review? removed

comment:6 Changed 5 years ago by tobiasz.cudnik

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [3699].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy