Removing lists in table cells results in collapsed table cells.

[Martin Kou]

To reproduce:

1. Open replacebyclass.html in Firefox/Safari/Opera.
2. Create a table.
3. Put caret to first cell.
4. Press Insert/Remove Unordered List twice.
5. Now the table cell cannot be selected in Firefox, or will give you strange caret positions in Safari/Opera.

[Martin Kou]

This is caused by lines 340 - 344 in list plugin.js. But I'm not sure what these four lines were originally meant to fix.

[Garry Yao]

These lines were for the logic of a special case regarding maintaining paragraph after remove list:

// Original Source
line1
<ul>
<li>item</li>
</ul>
<br />

// After arrayTolist, which append br for every line of items->

line1<br />
item<br />
<br />

// After L340 - 344, which figure out the br after item is redundant.
line1<br />
item
<br />

A simple fix I can imagine but not tested is:

var rootParent = groupObj.root.getParent();
newList.listNode.replace( groupObj.root );
rootParent.appendBogus();

}}}

[Martin Kou]

Garry's suggestion works, I've just added some safety checks for it.

[Garry Yao]

The safety check may not be necessary, even the root is guaranteed to be a block, could you give me an special case for it?

[Martin Kou]

Fixed with [3903].

Click here for more info about our SVN system.