Find & Replace causes "too much recursion"

[Damian]

When editing a moderate sized document with many searched for items, the search & replace can cause "too much recursion" errors in FF.

Sample document attached (taken from source view).

[Garry Yao]

The known Gecko Javascript stack deepth limit is 1K, however, I notice the browser is reporting unresponsive script at around 400.
We should be able to avoid this by rewriting the recursion algorithm to stack based.

[Damian]

The search and replace seems slower than in previous times, could this also be related to the problem?

[Garry Yao]

Replying to damo:

The search and replace seems slower than in previous times, could this also be related to the problem?

Do you mean by comparing with replacing feature of v2?

[Garry Yao]

The unresponsive script still show up with your sample page even with the iteration-based version, but that's been due to browser execution time limit.

[Garry Yao]

Cutting off the highlighting feature during replacement to speed it up.

[Garry Yao]

The new patch is take one step further, save one undo snapshot for all the replacement once, should result in an acceptable result now.

[Frederico Caldeira Knabben]

There is definitely a huge performance enhancement with the latest patch. A more complete test is needed on it, but it works pretty well for me.

There are just small notes regarding the changes on range.js:

• At line 735, we should have the following at this point:

if ( !collapsed && this.startContainer.equals( this.endContainer ) ) 

• The additions at line 775-776 seem unneeded. The range will never be collapsed at that point, because of the condition at line 748.

• The line space addition at line 724 seems unneeded.

[Garry Yao]

Fixing logic errors Fred found above and adding TC for the changes to CKEDITOR.dom.range::trim.

[Frederico Caldeira Knabben]

Please change the reference to "this.collapsed" to simply "collapsed" at line 748, as well as attaching the ! character to the parenthesis when committing.

[Garry Yao]

Fixed with [3734] and [3733].