Opened 15 years ago
Closed 15 years ago
#3804 closed Bug (fixed)
[IE] context menu position wrong for long document
| Reported by: | Garry Yao | Owned by: | Martin Kou |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | UI : Context Menu | Version: | |
| Keywords: | 3.0RC IE Review+ | Cc: |
Description (last modified by )
Reproducing Procedures
- Open the attached sample page in IE;
- Scroll the viewport to document end;
- Right click to show up context menu;
- Expected Result: Context menu show up at the position where mouse click happened.
- Actual Result: Context menu is not align correctly in view port.
Attachments (5)
Change History (15)
comment:1 Changed 15 years ago by
| Description: | modified (diff) |
|---|
Changed 15 years ago by
| Attachment: | sample_for_reproduce.html added |
|---|
comment:2 Changed 15 years ago by
| Keywords: | 3.0RC Review? added |
|---|---|
| Owner: | set to Garry Yao |
| Status: | new → assigned |
Not sure about the patch, but found L1106 of element.js is causing IE offset to be wrong:
editorFrame.getBoundingClientRect() // Always returning top as -1
Changed 15 years ago by
| Attachment: | 3804.patch added |
|---|
comment:3 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
Forcing the scroll check for IE should be wrong.
We're looking for the coordinates of the <html> element in our case, and therefore adding the scrollLeft and scrollTop to it is senseless - the html element is supposed to be the thing containing the scrollbar, not the other way round.
However, if you consider the common case where we're looking for the position of something inside that <html> element, then the scroll check would make sense.
Also, since different iframes can be rendered in standards/quirks mode separately, relying on CKEDITOR.env.quirks is also wrong.
Changed 15 years ago by
| Attachment: | 3804_2.patch added |
|---|
comment:4 Changed 15 years ago by
| Owner: | changed from Garry Yao to Martin Kou |
|---|---|
| Status: | assigned → new |
comment:5 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:6 Changed 15 years ago by
| Keywords: | Review? removed |
|---|
:(
Now the context menu is broken in non-IE browsers. Retracting the review request.
Changed 15 years ago by
| Attachment: | 3804_3.patch added |
|---|
comment:7 Changed 15 years ago by
| Keywords: | Review? added |
|---|
Changed 15 years ago by
| Attachment: | 3804_4.patch added |
|---|
comment:8 Changed 15 years ago by
| Status: | new → assigned |
|---|
Updated patch with comments explaining the purpose of the needAdjustScrollAndBorders flag.
comment:9 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:10 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed with [3742].
Click here for more info about our SVN system.
Sample page for reproducing