Opened 8 years ago

Closed 8 years ago

#3830 closed Bug (fixed)

Multi-cell selection does not work

Reported by: Damian Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed IBM Review+ Cc:

Description

When selecting a cell range in a table, the Cell Properties dialog should modify the properties of all cells in the range. Currently it only does for one cell.

Attachments (3)

3830.patch (2.9 KB) - added by Garry Yao 8 years ago.
3830_2.patch (3.1 KB) - added by Garry Yao 8 years ago.
3830_3.patch (2.7 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 8 years ago by Garry Yao

Keywords: Confirmed added

comment:2 Changed 8 years ago by Garry Yao

Resolution: wontfix
Status: newclosed

Cell Properties, as an 'editing' command, as other similar commands, is designed to deal with one element each time, which will result in ambiguous result when applied to multiple, currently we would keep the current feature as it is.

comment:3 Changed 8 years ago by Damian

This works as described in the ticket on FCKEditor 2.6. Why would CKEditor 3.0 be different?

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Resolution: wontfix
Status: closedreopened

I agree with damo. This is a required feature.

comment:5 Changed 8 years ago by Garry Yao

Owner: set to Garry Yao
Status: reopenednew

Changed 8 years ago by Garry Yao

Attachment: 3830.patch added

comment:6 Changed 8 years ago by Garry Yao

Keywords: Review? added
Status: newassigned

comment:7 Changed 8 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:8 Changed 8 years ago by Martin Kou

Please fix the curly bracket at tabletools plugin line 428 before committing - it should go to the next line.

comment:9 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review+ removed

Moving onShow and onOk out of the specific plugin is really strange. It sounds like a hack. What if I need another plugin that interact with the selected cell? Should I change tabletools again then?

Changed 8 years ago by Garry Yao

Attachment: 3830_2.patch added

comment:10 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:11 Changed 8 years ago by Martin Kou

Keywords: Review+ added; Review? removed

comment:12 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review+ removed

The changelog file has an incorrect change at line 1.

Changed 8 years ago by Garry Yao

Attachment: 3830_3.patch added

comment:13 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:14 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:15 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3774]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy