Opened 10 years ago

Closed 10 years ago

#3833 closed Bug (fixed)

Fixing CKEDITOR.dom.element test case

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: QA Version:
Keywords: Confirmed Review+ Cc:

Description

This's derived from #3693, where we don't suppose to normalize style text in core codes, so it's a matter of testing framework now.
We could it as a feature in CKEDITOR.test.

Attachments (2)

3833.patch (4.6 KB) - added by Garry Yao 10 years ago.
3833_2.patch (4.4 KB) - added by Garry Yao 10 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by Garry Yao

Keywords: Review? added
Status: newassigned

I've just ported Tobiasz's implementation here.

Changed 10 years ago by Garry Yao

Attachment: 3833.patch added

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The structure of the getAttribute function is complicated. It should be something as simple as:

var retval = element.getAttribute( attrName );

if ( attrName == 'style' )
{
    return retval
        .replace ...
}

return retval;

It will also make it simpler if we need to add other special attributes to it.

Changed 10 years ago by Garry Yao

Attachment: 3833_2.patch added

comment:3 Changed 10 years ago by Garry Yao

Keywords: Review? added; Review- removed

I assume changelog is not required for QA component?

comment:4 in reply to:  3 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

Replying to garry.yao:

I assume changelog is not required for QA component?

Yes, you're right. the changelog must have only public useful information.

comment:5 Changed 10 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3776].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy