Opened 16 years ago
Closed 16 years ago
#3833 closed Bug (fixed)
Fixing CKEDITOR.dom.element test case
Reported by: | Garry Yao | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | QA | Version: | |
Keywords: | Confirmed Review+ | Cc: |
Description
This's derived from #3693, where we don't suppose to normalize style text in core codes, so it's a matter of testing framework now.
We could it as a feature in CKEDITOR.test.
Attachments (2)
Change History (7)
comment:1 Changed 16 years ago by
Keywords: | Review? added |
---|---|
Status: | new → assigned |
Changed 16 years ago by
Attachment: | 3833.patch added |
---|
comment:2 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
The structure of the getAttribute function is complicated. It should be something as simple as:
var retval = element.getAttribute( attrName ); if ( attrName == 'style' ) { return retval .replace ... } return retval;
It will also make it simpler if we need to add other special attributes to it.
Changed 16 years ago by
Attachment: | 3833_2.patch added |
---|
comment:3 follow-up: 4 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
I assume changelog is not required for QA component?
comment:4 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
Replying to garry.yao:
I assume changelog is not required for QA component?
Yes, you're right. the changelog must have only public useful information.
I've just ported Tobiasz's implementation here.