Opened 10 years ago

Closed 9 years ago

#3842 closed Bug (wontfix)

Merge textnode broke by bookmark

Reported by: Garry Yao Owned by:
Priority: Normal Milestone:
Component: Core : Styles Version:
Keywords: Discussion HasPatch Cc:

Description

Currently once bookmark is created, broken text node will be forever stay in pieces, which result in a fracted document, have negative impacts on dom walking performance.
For this reason, possible treatment should be done in CKEDITOR.dom.range::moveToBookmark to merge sibling text nodes.

Attachments (1)

3842.patch (6.6 KB) - added by Garry Yao 10 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 10 years ago by Garry Yao

Summary: Merge text node when after selecting bookmarksMerge textnode broke by bookmark

Changed 10 years ago by Garry Yao

Attachment: 3842.patch added

comment:2 Changed 10 years ago by Garry Yao

Keywords: HasPatch added

comment:3 Changed 10 years ago by Garry Yao

Milestone: CKEditor 3.xCKEditor 3.1

comment:4 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.1
Resolution: wontfix
Status: newclosed

The real benefit of these changes are more theoretical than practical. We should really have hundreds of fragments to feel any drawback of it. A solution for it would just add overhead and code complexity.

The idea is not wrong anyway. We may reconsider it in the future, if needed.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy