Opened 8 years ago

Closed 8 years ago

#3882 closed Bug (fixed)

pasteFromWordRemoveStyle config key ignored

Reported by: Derek Price Owned by: Artur Formella
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: 3.0 RC
Keywords: Confirmed Review+ Cc:

Description

A default value of false is set _source/plugins/pastefromword/plugin.js for CKEDITOR.config.pasteFromWordRemoveStyle, but this config key is not used anywhere. I am attaching a simple patch to cause this key to set the default value for the "Remove Styles" checkbox in the Paste from Word dialog.

Keep up the great work!

Attachments (3)

ckeditor-config-pastefromword-removestyle.diff (620 bytes) - added by Derek Price 8 years ago.
two line change to implement default checkbox value based on config key
3882.patch (1.4 KB) - added by Artur Formella 8 years ago.
3882_2.patch (1.5 KB) - added by Artur Formella 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by Derek Price

two line change to implement default checkbox value based on config key

comment:1 Changed 8 years ago by Artur Formella

Keywords: Confirmed added; pastefromword config removestyle removed
Owner: set to Artur Formella
Status: newassigned
Summary: pasteFromWordRemoveStyle config key ignored [PATCH INCLUDED]pasteFromWordRemoveStyle config key ignored
Type: New FeatureBug

Changed 8 years ago by Artur Formella

Attachment: 3882.patch added

comment:2 Changed 8 years ago by Artur Formella

Keywords: Review? added

comment:3 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review- added; Review? removed

I'm sorry Artur but it seems that you're using undeclared pasteFromWordRemoveStyle and pasteFromWordIgnoreFontFace variables, instead of using those from config.

Changed 8 years ago by Artur Formella

Attachment: 3882_2.patch added

comment:4 Changed 8 years ago by Artur Formella

Keywords: Review? added; Review- removed

comment:5 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review+ added; Review? removed

comment:6 Changed 8 years ago by Artur Formella

Resolution: fixed
Status: assignedclosed

Fixed with [3851]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy