Opened 8 years ago

Closed 8 years ago

#3973 closed Bug (fixed)

Bulleted List Bug IE8

Reported by: wackyphill Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.0
Component: Core : Lists Version:
Keywords: IE Confirmed Review+ Cc:

Description

In the nightly build you can cause this error by doing the following:

Type some text on a new line. Then bold and underline the text.

Press ENTER to move to the next line. Then press the bulleted List Item on the toolbar to create a bulleted list.

This causes a javascript error.

Attachments (1)

3973.patch (1.9 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by Garry Yao

Component: GeneralCore : Lists
Keywords: IE Confirmed added
Owner: set to Garry Yao
Priority: HighNormal
Status: newassigned

Changed 8 years ago by Garry Yao

Attachment: 3973.patch added

comment:2 Changed 8 years ago by Garry Yao

Keywords: Review? added

Regression from #3887.
The error is triggered by the following steps:

  1. When apply inline style, a empty text node is created after the <body> due to the following dirty codes:
    		// Probably the document end is reached, we need a marker node.
    		if ( !lastNode )
    		{
    				lastNode = document.createText( '' );
    				lastNode.insertAfter( range.endContainer );
    		}
    
  2. When create list, the special treatment logic added in [3850] is incorrectly triggered, where it try to check if the empty text node is at the boundary of a <html> element, result in an error.

I'm providing a temporary fix here while a decent solution should be found later.

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

May be temporary, but it's logic and efficient.

comment:4 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [3926]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy