[FF] Can not second save

[lisaj]

In firefox (tested 3.0, 3.5) if send data via ajax and recreate editor second send no change text area. I create test file with sam error.

1. Open file
2. Write text
3. Send

Text is set correctly

4. Write another text
5. Send

Old text is set

[Garry Yao]

Providing a reduced TC.
The bug is actually due to the call to editor.destroy() on submit event.

[Garry Yao]

Sample page for reproducing

[Garry Yao]

@lisaj
I didn't test the patch with your original problematic sample page, please help us to verify it with nightly build after this ticket get fixed.

[Frederico Caldeira Knabben]

The proposed solution will not work on the following case:

1. Create editor1 : the "original" form.submit function is replaced with "internalFunc1" (named just to make it simple to understand), saving "original".

2. Create editor2: the "internalFunc1" reference is now replaced with "internalFunc2", saving "internalFunc1".

3. Destroy editor1: the "original" function is set to form.submit, which should be ok.

4. Destroy editor2: the "internalFunc1" function is set to form.submit... things are broken again.

So, it should be better to not interfere on the function calling chain, where "internalFunc2" calls "internalFunc1" which calls "original". We could change this model, but then the change would be much more drastic.

To maintain the current code structure, we could simply set editor.dead = true into destroy(), and then make this "dead" check before calling editor.updateElement(), in attachToForm, eventually removing the form.on('submit') handler at that point.

[Frederico Caldeira Knabben]

The code is ok, but the "afterDestroy" event is not thrown anywhere. Other than that, let's simply call this event "destroy". We could use "before" and "after" for every single event, but we must keep it logical and simple. The "destroy" event should be thrown when the editor is about to be destroyed.

[Garry Yao]

Oh, that's my fault.

[Garry Yao]

Fixed with [3949].

[lisaj]

Its working good.