Ticket #4107 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Font combo inconsistency

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: Core : Styles Version:
Keywords: Confirmed Review+ Cc:

Description (last modified by garry.yao) (diff)

Reproducing Procedures

  1. Open the 'replace by class' sample page in Firefox;
  2. Assign 'Georgia' font to word 'This';
  3. Open the 'replace by class' sample page in IE7;
  4. Copy the source of editor from FF into IE;
  5. Click inside word 'This';
    • Actual Result: The 'Font' combo is not updated.
    • Expected Result: The 'Font' combo is populated with 'Georgia'.

Attachments

4107.patch (2.6 KB) - added by garry.yao 5 years ago.
4107_2.patch (1.5 KB) - added by garry.yao 5 years ago.

Change History

comment:1 Changed 5 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to assigned
  • Keywords Confirmed added

Changed 5 years ago by garry.yao

comment:2 Changed 5 years ago by garry.yao

  • Keywords Review? added

Caused by font style text various in format:

font-family: Georgia,serif

vs

font-family: georgia, serif

comment:3 Changed 5 years ago by fredck

  • Keywords Review- added; Review? removed
  • Milestone changed from CKEditor 3.0 to CKEditor 3.1

I understand the generalization here, but this is supposed to be a localized issue, exclusive to the fonts combo (we'll rarely have it elsewhere), so the fix could go directly to that combo code.

Also, that regex can be simplified, if we're simply looking for replacing spaces after the commas.

Changed 5 years ago by garry.yao

comment:4 Changed 5 years ago by garry.yao

  • Keywords Review? added; Review- removed
  • Description modified (diff)

Update the description for accurate reproducing.

comment:5 Changed 5 years ago by fredck

  • Keywords Review+ added; Review? removed

On commit, please:

  • Move the test to the new proper location.
  • Add the changelog entry for it.

comment:6 Changed 5 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [4318].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy