Opened 15 years ago
Closed 15 years ago
#4140 closed Bug (fixed)
Releaser: tools.repeat issue
| Reported by: | Artur Formella | Owned by: | Frederico Caldeira Knabben |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | QA | Version: | |
| Keywords: | Review+ | Cc: | Wiktor Walc |
Description
repeat : function( str, times )
{
return new Array( times + 1 ).join( str );
}
After release process:
repeat : function (f, g)
{
return [g + 1].join(f);
}
Test case: http://nightly.ckeditor.com/latest/ckeditor/_tests/core/tools.html
Attachments (2)
Change History (7)
comment:1 Changed 15 years ago by
| Owner: | set to Tobiasz Cudnik |
|---|---|
| Status: | new → assigned |
Changed 15 years ago by
| Attachment: | 4140.patch added |
|---|
comment:2 Changed 15 years ago by
| Keywords: | Review? added |
|---|
comment:3 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|---|
| Owner: | changed from Tobiasz Cudnik to Frederico Caldeira Knabben |
| Status: | assigned → new |
It's important to have the packager working well in all cases. It's hard to remember all workarounds for it. And after all, fixing is is quite simple (and fun!).
Changed 15 years ago by
| Attachment: | 4140_2.patch added |
|---|
comment:4 Changed 15 years ago by
| Cc: | Wiktor Walc added |
|---|---|
| Keywords: | Review? added; Review- removed |
| Status: | new → assigned |
I would ask Wiktor to please review it, committing the patch and updating the compiled packager.
comment:5 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
This simple workaround resolves the issue in this particular method. No other method is affected by this issue, so i'm proposing resolving releaser issue in some later ticket and use this patch for final release.