Opened 10 years ago

Closed 10 years ago

#4140 closed Bug (fixed)

Releaser: tools.repeat issue

Reported by: Artur Formella Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.0
Component: QA Version:
Keywords: Review+ Cc: Wiktor Walc

Description

repeat : function( str, times )
{
	return new Array( times + 1 ).join( str );
}

After release process:

repeat : function (f, g)
{
	return [g + 1].join(f);
}

Test case: http://nightly.ckeditor.com/latest/ckeditor/_tests/core/tools.html

Attachments (2)

4140.patch (577 bytes) - added by Tobiasz Cudnik 10 years ago.
4140_2.patch (1.2 KB) - added by Frederico Caldeira Knabben 10 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 10 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 10 years ago by Tobiasz Cudnik

Attachment: 4140.patch added

comment:2 Changed 10 years ago by Tobiasz Cudnik

Keywords: Review? added

This simple workaround resolves the issue in this particular method. No other method is affected by this issue, so i'm proposing resolving releaser issue in some later ticket and use this patch for final release.

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
Owner: changed from Tobiasz Cudnik to Frederico Caldeira Knabben
Status: assignednew

It's important to have the packager working well in all cases. It's hard to remember all workarounds for it. And after all, fixing is is quite simple (and fun!).

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 4140_2.patch added

comment:4 Changed 10 years ago by Frederico Caldeira Knabben

Cc: Wiktor Walc added
Keywords: Review? added; Review- removed
Status: newassigned

I would ask Wiktor to please review it, committing the patch and updating the compiled packager.

comment:5 Changed 10 years ago by Wiktor Walc

Keywords: Review+ added; Review? removed
Resolution: fixed
Status: assignedclosed

Fixed with [4008], [4009].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy