Opened 8 years ago

Closed 8 years ago

#4165 closed Bug (fixed)

rtrim and ltrim fails in various browsers

Reported by: Tobiasz Cudnik Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

From CKEDITOR.tools, rtrim and ltrim fails in various browsers (FF3.5, Safari4, FF2, FF3, Safari3). Full trim in done instead of trimming only the desired side.

Attachments (3)

4165.patch (643 bytes) - added by Tobiasz Cudnik 8 years ago.
4165_2.patch (723 bytes) - added by Tobiasz Cudnik 8 years ago.
4165_3.patch (1.7 KB) - added by Tobiasz Cudnik 8 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

comment:2 Changed 8 years ago by Tobiasz Cudnik

Actually this issue is related to CKEDITOR.dom.node, not tools namespace.

Changed 8 years ago by Tobiasz Cudnik

Attachment: 4165.patch added

comment:3 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review? added

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

I've talked with Garr yabout something similar today, and it's better to have the test changed so it doesn't need to have spaces at the end of the lines, as they will be definitely removed by our dev tools.

Changed 8 years ago by Tobiasz Cudnik

Attachment: 4165_2.patch added

Changed 8 years ago by Tobiasz Cudnik

Attachment: 4165_3.patch added

comment:5 Changed 8 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

comment:6 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:7 Changed 8 years ago by Tobiasz Cudnik

Resolution: fixed
Status: assignedclosed

Fixed with [4039].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy