Opened 10 years ago

Closed 10 years ago

#4177 closed Bug (fixed)

[Safari] core/editor/test_config_inpage randomly failed

Reported by: Garry Yao Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.0
Component: QA Version:
Keywords: Safari Confirmed Review+ Cc:

Description

The inline config should be checked only after 'configLoaded' is fired.

Attachments (4)

4177.patch (1.6 KB) - added by Garry Yao 10 years ago.
4177_2.patch (1.7 KB) - added by Garry Yao 10 years ago.
4177_3.patch (1.7 KB) - added by Garry Yao 10 years ago.
4177_4.patch (1.7 KB) - added by Frederico Caldeira Knabben 10 years ago.

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by Garry Yao

Attachment: 4177.patch added

comment:1 Changed 10 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The event registration should be set in the replace call. If things are cached, the configLoaded could be called even before the event registration. It just happend to me with Firefox.

Changed 10 years ago by Garry Yao

Attachment: 4177_2.patch added

comment:3 Changed 10 years ago by Garry Yao

Keywords: Review? added; Review- removed

Changed 10 years ago by Garry Yao

Attachment: 4177_3.patch added

Changed 10 years ago by Frederico Caldeira Knabben

Attachment: 4177_4.patch added

comment:4 Changed 10 years ago by Frederico Caldeira Knabben

Owner: changed from Garry Yao to Frederico Caldeira Knabben
Status: assignednew

I've made some small simplifications to it.

comment:5 Changed 10 years ago by Tobiasz Cudnik

Keywords: Review+ added; Review? removed

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: newclosed

Fixed with [4044].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy