Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#419 closed Bug (fixed)

Dangerous recursive file deletion bug in build_release.bat

Reported by: Ulf Haueisen Owned by:
Priority: Must have (possibly next milestone) Milestone: FCKeditor 2.4.3
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Cc:

Description

There's a dangerous bug in trunk/_dev/build_release.bat which occurs if the environment variable FCK_RELEASER_PATH is not set. Because fckreleaser.php is called with an empty string as second parameter, the whole drive will be recursively deleted.

Solution:

Change

php releaser/fckreleaser.php ../ "%FCK_RELEASER_PATH%" "%RELEASER_VERSION%"

To

php releaser/fckreleaser.php ../ "%RELEASER_PATH%" "%RELEASER_VERSION%"

Thanks, Ulf Haueisen

Change History (5)

comment:1 Changed 12 years ago by Frederico Caldeira Knabben

What a typo! Thanks for the advice ulf.

Fixed with [271].

comment:2 Changed 12 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: newclosed

comment:3 in reply to:  1 ; Changed 12 years ago by Ulf Haueisen

Replying to fredck:

Never mind, it cleared half of my data partition, but I had a fresh backup ;)

comment:4 in reply to:  3 Changed 12 years ago by Frederico Caldeira Knabben

Replying to ulf:

Never mind, it cleared half of my data partition, but I had a fresh backup ;)

:-O

comment:5 Changed 12 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.5FCKeditor 2.4.3
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy