Opened 10 years ago

Last modified 8 years ago

#4195 review_failed Bug

Inline quotion style problematic

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone:
Component: Core : Styles Version: SVN (CKEditor) - OLD
Keywords: Confirmed Cc:

Description

Sometimes inline style should own priority, style with higher priority should be applied at a more high level. Here's a concrete example

Reproducing Procedures

  1. Open the 'replace by class' sample page;
  2. Load the following content with selection:
    <p>
    	<strong>[some</strong>test<strong>text]</strong></p>
    
  3. Apple 'Line Quatation" from 'Format' combo;
    • Actual Result:
      <p>
      	<strong>so<q>me</q></strong><q>test</q><strong><q>te</q>xt</strong></p>
      
    • Expected Result: The quatatoin style doesn't break into pieces
      <p>
      	<strong>so</strong><q><strong>me</strong>test<strong>te</strong></q><strong>xt</strong></p>
      

Attachments (1)

4195.patch (2.5 KB) - added by Garry Yao 9 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by Garry Yao

Milestone: CKEditor 3.1CKEditor 3.2
Version: SVN (CKEditor)

comment:2 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.2CKEditor 3.3

comment:3 Changed 9 years ago by Garry Yao

Keywords: Confirmed added
Owner: set to Garry Yao
Status: newassigned

Similar with #3599.

Changed 9 years ago by Garry Yao

Attachment: 4195.patch added

comment:4 Changed 9 years ago by Garry Yao

Keywords: Review? added

comment:5 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.3CKEditor 3.x

The "intact" name doesn't look like intuitive for this property in the style definition. We must think about something better.

comment:6 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

Milestone CKEditor 3.x deleted

comment:7 Changed 8 years ago by Frederico Caldeira Knabben

Status: reviewreview_failed

This patch needs to be updated. Additionally, instead of "intact", let's call the property "maximize" or "avoidBreak", or anything that makes it more meaningful.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy