Opened 10 years ago

Closed 7 years ago

#4214 closed Bug (wontfix)

Maximize bugs

Reported by: Mark Owned by:
Priority: Normal Milestone:
Component: General Version: FCKeditor 2.4.2
Keywords: HasPatch Cc:

Description

In Firefox 2.x, 3.x, 3.5.x and Safari 4.x (possibly others) the maximize feature is setting the body height/width to 0px which is causing the the iframe to be hidden. Simply removing this 0px setting seems to resolve the issue for these two, however, breaks Opera if they are removed. I have not tested Safari 3.x, Opera 10, or Chrome.

Can confirm it works correctly in IE7/8 & Opera 9.64

Note: One unusual setup in my code is that the body element is position: absolute; (100% height trick)

Also of note related to this bug - when using maximize the existing styles of containing elements are overwritten by FCK. ie: <body style="xyz" is being replaced with FCK maximize code where it should add to it instead.

Change History (3)

comment:1 Changed 10 years ago by Mark

Figured it out. Specific details of bug:

FCKeditor assumes position of body is at top: 0px; left: 0px;

Reason it occurred:

Using the height trick I mentioned involves setting the body to visibility:hidden; position:absolute; bottom: 0px; and at load using JavaScript to reset the height on specific elements before making it visible again. This allows for the behaviour of <div style="width: 100%"> to be applied to height: 100% as well.

The fix:

When setting height/width/z-index etc also set top/left to 0px.

Note additional (minor bug): z-index is being set on unpositioned elements

As to the second part of this bug, style elements being "overwritten". This is problematic. While it does re-set these properties properly, it does not allow for more advanced techniques to be used with FCK. Specifically: One desired model is to have FCK maximized over the actual content. FCK can then be used like a sidebar and "tucked away" to preview the changes in real time/in an existing template. If the editor is modifying properties outside of it's main container then this is impossible. A model similar to openWYSIWYG's maximize would cause fewer issues and be computationally less expensive.

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: HasPatch added

comment:3 Changed 7 years ago by Jakub Ś

Resolution: wontfix
Status: newclosed

FCKeditor was retired and is no longer supported. All active development was moved to its successor, CKEditor 3.x, that is a fully mature and far superior product. We recommend you upgrade as soon as possible since this issue is no longer a problem in current code base.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy