Opened 8 years ago

Closed 8 years ago

#4401 closed Bug (fixed)

Link removeContents of upload tab not working

Reported by: wimpie3 Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: UI : Dialogs Version: 3.0
Keywords: Confirmed Review+ Cc: wim.dewijngaert@…

Description (last modified by Frederico Caldeira Knabben)

Whe using the function below, the LINK dialog isn't shown anymore (javascript error). Comment out the line "dialogDefinition.removeContents( 'upload' );" and everything works again.

CKEDITOR.on( 'dialogDefinition', function( ev ) {
	var dialogName = ev.data.name;
	var dialogDefinition = ev.data.definition;
	if ( dialogName == 'link' )	{
		dialogDefinition.removeContents( 'advanced' );
		dialogDefinition.removeContents( 'upload' );
	}
});

Attachments (1)

4401.patch (635 bytes) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by wimpie3

Cc: wim.dewijngaert@… added

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Component: GeneralUI : Dialogs
Description: modified (diff)
Priority: HighNormal

Changed 8 years ago by Garry Yao

Attachment: 4401.patch added

comment:3 Changed 8 years ago by Garry Yao

Keywords: Confirmed Review? added
Owner: set to Garry Yao
Status: newassigned

'Info' tab page should not assume the pre-existence of 'Upload' page.

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:5 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [4443].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy