Opened 8 years ago

Closed 7 years ago

#4479 closed Bug (fixed)

Styles combo is not "active" until it's clicked

Reported by: Alfonso Martínez de Lizarrondo Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.3
Component: General Version: 3.0
Keywords: Confirmed Review+ Cc:

Description

When the editor is loaded, the Styles combo doesn't react to changes in the content because it doesn't load the styles definition file until it's clicked, so it doesn't reflect the style of the current selection.

After the combo is clicked once and the definition file is loaded then it behaves normally.

Attachments (2)

4479.patch (4.2 KB) - added by Garry Yao 7 years ago.
4479_2.patch (3.5 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by Garry Yao

Component: Core : StylesGeneral
Keywords: Confirmed added
Milestone: CKEditor 3.1

IMO it's a very good catch!

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.1CKEditor 3.2

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.2CKEditor 3.3

comment:4 Changed 7 years ago by Alfonso Martínez de Lizarrondo

#5072 has been marked as dup

Changed 7 years ago by Garry Yao

Attachment: 4479.patch added

comment:5 Changed 7 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

Introduce a config option to control over that.

comment:6 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review- added; Review? removed

Instead of putting the load in onRender I would use editor.on( 'instanceReady'), and then I think that it won't need any config option but I can live with it if other people think that it's better that way.

Changed 7 years ago by Garry Yao

Attachment: 4479_2.patch added

comment:7 Changed 7 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:8 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review+ added; Review? removed

Now as the stylesSet will be loaded always we could almost remove the call to loadStylesSet in the richCombo::init, but for safety I guess that it won't hurt to leave it that way.

comment:9 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [5243].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy