Opened 8 years ago

Closed 8 years ago

#4522 closed Bug (fixed)

[IE] Unable to redo on inserted element + typing

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: Core : Undo & Redo Version: SVN (CKEditor) - OLD
Keywords: IE Review+ Cc:

Description

Environments

IE6/IE7 (IE8 works well)

Procedures

  1. Focus the editor;
  2. Open the 'Smiley' dialog and insert an icon;
  3. Start typing a few words;
  4. Press 'Undo' button or 'Ctrl-Z' key;
  • Actual Result: Typed words are removed;
  1. Press 'Undo' button or 'Ctrl-Z' key again;
  • Expected Result: Icon is removed.
  • Actual Result: Unable to remove the icon, even 'Undo' button is enable there.

Attachments (3)

4522.patch (1.0 KB) - added by Garry Yao 8 years ago.
4522_2.patch (922 bytes) - added by Garry Yao 8 years ago.
4522_3.patch (1.1 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by Garry Yao

Attachment: 4522.patch added

comment:1 Changed 8 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

I don't see any difference after the patch.

Changed 8 years ago by Garry Yao

Attachment: 4522_2.patch added

comment:3 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed
Version: SVN (CKEditor)

@fredck You're using IE8 quirks mode for testing and the above patch has wrong detection.

It's even safer to target the fix to all browsers.

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

We should not make this fix viral, impacting on the performance of good browsers. Let's limit this fix to IE only, using CKEDITOR.env.ie8Compat to avoid it into IE8 also (as long as it's really true that IE8 is ok with it).

Changed 8 years ago by Garry Yao

Attachment: 4522_3.patch added

comment:5 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:6 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:7 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [4605].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy