Opened 8 years ago

Closed 7 years ago

#4553 closed Bug (fixed)

checkDirty() returns 'true' when there is no change in context

Reported by: markuspaek Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.3
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc:

Description

please find the enclosed.

Once an editor is created, just click the editing area, then the checkDirty() returns 'true' even though no change was made.

In other words, the context is empty with code <textarea></textarea>, but checkDirty() returns 'true' nonetheless.

FireFox 3.5.3 Windows XP

Attachments (2)

replacebycode2.html (2.8 KB) - added by markuspaek 8 years ago.
checkDirty.patch.txt (553 bytes) - added by markuspaek 8 years ago.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by markuspaek

Attachment: replacebycode2.html added

comment:1 Changed 8 years ago by Garry Yao

Keywords: Pending added
Version: 3.0.1

It should have been fixed by #4385, will you please confirm again with v3.0.1?

comment:2 Changed 8 years ago by markuspaek

Yes, I got the problem with v3.0.1. Thank you.

comment:3 Changed 8 years ago by markuspaek

It seems you missed restoreDirty() while fixing Ticket#3864. I took the liberty including the missing part. Please take a look and see if it works. Cheers!

Changed 8 years ago by markuspaek

Attachment: checkDirty.patch.txt added

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Pending removed

comment:5 Changed 8 years ago by markuspaek

Any updates?

Thanks.

comment:6 Changed 8 years ago by Garry Yao

Keywords: Confirmed HasPatch added
Milestone: CKEditor 3.3
Version: SVN (CKEditor)

comment:7 Changed 7 years ago by Garry Yao

Keywords: Review+ added; HasPatch removed
Owner: set to Garry Yao
Status: newassigned

Thanks for remind and the patch.

comment:8 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [5229].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy