Opened 8 years ago

Closed 8 years ago

#4612 closed New Feature (fixed)

Link text is not updated when link protocol is changed

Reported by: Joe Kavanagh Owned by: Minh Nguyen
Priority: Normal Milestone: CKEditor 3.2
Component: General Version: 3.0
Keywords: IBM Review+ Cc: damian.chojna@…

Description (last modified by Frederico Caldeira Knabben)

  1. Click on the Link button to open the Link dialog.
  2. Enter a URL, for example www.bbc.co.uk
  3. Choose https:// for the protocol and click OK.
  4. Observe that the link is displayed as https://www.bbc.co.uk
  5. Right click on the link and open the Link dialog.
  6. Update the protocol to ftp:// and click OK
  7. Observe that the link text remains as https://www.bbc.co.uk.

If you view the HTML source you can see that the link text has not updated:

<a href="ftp://www.bbc.co.uk">https://www.bbc.co.uk</a>

Attachments (2)

4612.patch (2.8 KB) - added by Minh Nguyen 8 years ago.
4612_2.patch (1.1 KB) - added by Minh Nguyen 8 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by Frederico Caldeira Knabben

Description: modified (diff)

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.1CKEditor 3.2
Type: BugNew Feature

There is no bug here. It's missing feature. The fact is that the dialog doesn't look at the text when changing a link. It just assumes that the text present there is something written by the user; it could be an URL or any other kind of text.

We could consider a new feature that, in the case the link text matches the original href value, the text is also changed when updating the URL.

comment:3 Changed 8 years ago by Minh Nguyen

Keywords: Review? added
Owner: set to Minh Nguyen
Status: newassigned

Changed 8 years ago by Minh Nguyen

Attachment: 4612.patch added

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The idea about having a new field for the link text is interesting, but it's out of the scope of this ticket. A dedicated ticket could be opened for that. We should instead provide a simpler solution for it.

Changed 8 years ago by Minh Nguyen

Attachment: 4612_2.patch added

comment:5 Changed 8 years ago by Minh Nguyen

Keywords: Review? added; Review- removed

comment:6 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review+ added; Review? removed

comment:7 Changed 8 years ago by Minh Nguyen

Resolution: fixed
Status: assignedclosed

Fixed with [4997].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy