Opened 9 years ago

Closed 9 years ago

#4692 closed Bug (fixed)

CKPackager remove mandatory parenthsis

Reported by: Garry Yao Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone:
Component: Project : CKPackager Version:
Keywords: Confirmed Review+ Cc:

Description

For the following codes

array.splice( ( length--, i-- ), 1 );

CKPackager will output into:

array.splice( length--, i--, 1 );

Attachments (3)

4692.patch (1.8 KB) - added by Garry Yao 9 years ago.
4692_2.patch (1.8 KB) - added by Frederico Caldeira Knabben 9 years ago.
4692_3.patch (2.5 KB) - added by Frederico Caldeira Knabben 9 years ago.

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by Garry Yao

Attachment: 4692.patch added

comment:1 Changed 9 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
Owner: changed from Garry Yao to Frederico Caldeira Knabben
Status: assignednew

I think this issue can be handled in a different way. The patch actually forces parenthesis even when not needed. I'm already coding something for it.

Changed 9 years ago by Frederico Caldeira Knabben

Attachment: 4692_2.patch added

comment:3 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed
Status: newassigned

comment:4 Changed 9 years ago by Wiktor Walc

Keywords: Review- added; Review? removed

I'm not sure if we'll ever use such code, but there is a code that is not compressed properly:

var a=(1,2,3,4);

it is changed into

var a=1,2,3,4;

Changed 9 years ago by Frederico Caldeira Knabben

Attachment: 4692_3.patch added

comment:5 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed

These issues where not really related to the previous patch, but they needed to be fixed also. The new patch contemplates it.

comment:6 Changed 9 years ago by Wiktor Walc

Keywords: Review+ added; Review? removed

comment:7 Changed 9 years ago by Wiktor Walc

Resolution: fixed
Status: assignedclosed

Fixed with [4671] and [4672].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy