Support fakeobjects for comments

[Frederico Caldeira Knabben]

Currently, it's not possible to replace HTML comments with fake elements. We should provide support for it.

[Frederico Caldeira Knabben]

The motivation to code this feature right now is the support for break and pagebreak comments in Drupal. I've attached a proposal plugin for a Drupal plugin for it, which uses the features introduced in the proposed patch.

To activate it for testing, after applying the patch, simply unzip the file into the plugins folder and use the following config.js contents:

CKEDITOR.editorConfig = function( config )
{
	config.extraPlugins = 'drupalbreaks';
	
	this.on( 'pluginsLoaded', function()
	{
		CKEDITOR.config.toolbar_Full.push( [ 'DrupalBreak', 'DrupalPageBreak' ] );
	});
};

The basic idea is that we must always work to make plugins development a simply and exciting task. For that, our API must be flexible and all complexity must be handled by the core code.

[Frederico Caldeira Knabben]

Drupal plugin using this feature. Updated to support tables, lists, blockquotes, etc.

[Garry Yao]

Nice patch, kudo!
And here come some small problems that I found:

L18-L42 of fakeobject/plugin.js

There should be some guard since we should also considering non-element fake now. ( Identified by resize the fake comment and switch to source you'll get a JavaScript error);

L114 of the same plugin

if ( fakeElement.getAttribute( '_cke_real_node_type' ) == CKEDITOR.NODE_COMMENT )
	return null;

How about

if ( fakeElement.getAttribute( '_cke_real_node_type' ) != CKEDITOR.NODE_ELEMENT )
	return null;

[Garry Yao]

Note that the priority changes to the default rules may have impact on existing plugins which may assume the default rules are applied in prior, if it's not a necessary to have it, we can hold this change.

[Frederico Caldeira Knabben]

Added a new patch based on a chat with Garry, where he stated that it's not a good idea to have the getText method into CKEDITOR.dom.comment, as this method is been (improperly) used in the code to detect node types (the type property should be used instead).

[Frederico Caldeira Knabben]

Fixed with [4556] (3.1.x branch).

[Wiktor Walc]

Added missing entry in ckeditor.pack with [4558].