#4746 closed Bug (fixed)
insertHtml left trim text
Reported by: | Garry Yao | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.4.3 |
Component: | General | Version: | 3.0 |
Keywords: | Confirmed | Cc: | jamcunni@… |
Description
Reproducing Procedures
- Open the 'api' sample page, load the editor with the following content and selection.
some^text
- Load the insertion area with the following content:
insertion
- Click on 'Insert HTML' button.
- Switch to 'Source' mode.
- Actual Result:
<p> someinsertion text</p>
- Expected Result:
<p> some insertion text</p>
Note that the left side whitespace has been trimmed, which is wrong.
Attachments (2)
Change History (20)
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
We could have an option on the dataprocessor to control the parser behavior properly.
comment:3 Changed 14 years ago by
Milestone: | CKEditor 3.2 → CKEditor 3.3 |
---|
comment:4 Changed 14 years ago by
Milestone: | CKEditor 3.3 → CKEditor 3.4 |
---|---|
Version: | → 3.0 |
comment:5 Changed 13 years ago by
Owner: | set to Garry Yao |
---|---|
Status: | new → assigned |
Another TC: Inserting inside a <pre> collapses all line-breaks and tabs.
Changed 13 years ago by
Attachment: | 4746.patch added |
---|
comment:6 Changed 13 years ago by
Keywords: | Review? added |
---|
Introduce an idea that allows context sensitive html parsing with ease.
comment:7 Changed 13 years ago by
Milestone: | CKEditor 3.4 → CKEditor 3.5 |
---|
comment:8 Changed 13 years ago by
Status: | review → review_failed |
---|
The element should not be noticable in the elements path.
Changed 13 years ago by
Attachment: | 4746_2.patch added |
---|
comment:9 follow-up: 10 Changed 13 years ago by
Status: | review_failed → review |
---|
Align patch with trunk. @Saar, this's a virtual context that only seen in the parser, it will not exist in wysiwyg at all.
comment:10 Changed 13 years ago by
Status: | review → review_failed |
---|
Replying to garry.yao:
@Saar, this's a virtual context that only seen in the parser, it will not exist in wysiwyg at all.
I can move the cursor into the span, so it's visible in the elements path. The user should not know we have a temporary span there.
4746_2 is not working for me on IE for some reason, 4746 does though.
Also please note that after the patch the data variable is set twice.
comment:11 Changed 13 years ago by
Milestone: | CKEditor 3.4.2 → CKEditor 3.5 |
---|
Well, it seems I'm quite naive for IE as even we fixed our parser, IE's 'pasteHTML' still won't let this leading space pass, so the fix only partially work, in this case we will need to again wait for #5309, defer it to 3.5
comment:12 Changed 13 years ago by
Milestone: | CKEditor 3.5 → CKeditor 3.4.3 |
---|
comment:13 Changed 13 years ago by
Status: | review_failed → assigned |
---|
comment:14 Changed 13 years ago by
Owner: | Garry Yao deleted |
---|---|
Status: | assigned → new |
comment:15 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Now that we've reworked the editor::insertText method which should be relied on for inserting plain text (where leading whitespaces are preserved).
comment:16 Changed 13 years ago by
The initial test case is still reproducible on the nightly build and should be reopened.
comment:17 Changed 13 years ago by
Cc: | jamcunni@… added |
---|
Ticket Test added at :
http://ckeditor.t/tt/4746/1.html.