Opened 8 years ago

Closed 7 years ago

#4779 closed New Feature (fixed)

Setting CKEditor width should automatically adjust resize_minWidth

Reported by: Wiktor Walc Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.4
Component: UI : Toolbar Version:
Keywords: Confirmed Review+ Cc:

Description

same applies for editor height.

Consider the following scenario: page with a column having fixed width 540px and padding 20px. Developer sets CKEditor width to 500px.

Now user entering text in CKEditor wants to change editor's height. What will happen? CKEditor will automatically resize to 750px (default resize_minWidth is 750px).

Instead of forcing developers to look for resize_minWidth and setting it to lower value than width, I think we should change resize_minWidth to width automatically if width has been set and is lower than resize_minWidth.

Attachments (2)

4779.patch (2.6 KB) - added by Garry Yao 7 years ago.
4779_2.patch (3.1 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added
Milestone: CKEditor 3.3

comment:2 Changed 8 years ago by Wiktor Walc

Summary: Setting CKEditor width should automatically adjust resize_maxwidthSetting CKEditor width should automatically adjust resize_minWidth

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.3CKEditor 3.4

comment:4 Changed 7 years ago by Garry Yao

Component: GeneralUI : Toolbar
Milestone: CKEditor 3.4CKEditor 3.3

I see this actually a pretty common case and I've seen others complained of it in forum.
In effect it happens even there's no configured width/height, but whenever the start layout size of editor is somehow smaller than our default value (750px), in such case, by setting min_resize value to actual size will prevent editor from shrinking, so how about having a dynamic min_resize setting to 1/2 of the original size?

Changed 7 years ago by Garry Yao

Attachment: 4779.patch added

comment:5 Changed 7 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

comment:6 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.3CKEditor 3.4

comment:7 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

250 may be a too small value. So, let's make it simple (KISS), by simply readjusting resize_minWidth to the start width if it's bigger than that.

Changed 7 years ago by Garry Yao

Attachment: 4779_2.patch added

comment:8 Changed 7 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:9 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review+ added; Review? removed

comment:10 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: assignedclosed

Fixed with [5663]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy