Opened 9 years ago

Closed 9 years ago

#4781 closed Bug (fixed)

Insert any template content start with html table result in empty paragraph

Reported by: Garry Yao Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed 3.0.2 Review+ Cc:

Description

Reproducing Procedures

  1. Open 'replacebyclass' sample pages, open 'Templates' dialog.
  2. Make sure 'Replace actual contents' is checked and click on 'Strange Template' to insert it.

Attachments (6)

4781.patch (1.0 KB) - added by Frederico Caldeira Knabben 9 years ago.
4781_2.patch (1.2 KB) - added by Garry Yao 9 years ago.
4781_3.patch (3.0 KB) - added by Frederico Caldeira Knabben 9 years ago.
4781_4.patch (3.2 KB) - added by Frederico Caldeira Knabben 9 years ago.
4781_5.patch (4.2 KB) - added by Frederico Caldeira Knabben 9 years ago.
4781_6.patch (3.1 KB) - added by Frederico Caldeira Knabben 9 years ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 9 years ago by Frederico Caldeira Knabben

Regression introduced with [4539].

comment:2 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: 3.0.2 added

Changed 9 years ago by Frederico Caldeira Knabben

Attachment: 4781.patch added

comment:3 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review? added
Owner: set to Frederico Caldeira Knabben
Status: newassigned

comment:4 Changed 9 years ago by Garry Yao

Keywords: Review- added; Review? removed

That's the right fix, while two improvement could be considered:

  1. We could safely remove the short circuit at L1615, just be greedy to until meet the deepest editable element;
  2. White-spaces will break things.

Ticket Test added at :
http://ckeditor.t/tt/4781/1.html.

Changed 9 years ago by Garry Yao

Attachment: 4781_2.patch added

Changed 9 years ago by Frederico Caldeira Knabben

Attachment: 4781_3.patch added

comment:5 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed

I've refacted the moveToElementEditStart function, making it bulletproof.

Changed 9 years ago by Frederico Caldeira Knabben

Attachment: 4781_4.patch added

comment:6 Changed 9 years ago by Frederico Caldeira Knabben

Fixed yet another small issue in the walker with the new patch.

comment:7 Changed 9 years ago by Frederico Caldeira Knabben

Tests updated for the latest patch:
http://ckeditor.t/tt/4781/1.html.

Changed 9 years ago by Frederico Caldeira Knabben

Attachment: 4781_5.patch added

comment:8 Changed 9 years ago by Frederico Caldeira Knabben

Tests updated for the latest patch:
http://ckeditor.t/tt/4781/1.html

comment:9 Changed 9 years ago by Garry Yao

Keywords: Review- added; Review? removed

The patch works well for me except for the following issues:

  1. Changes in the walker are not used.
  2. Please cache the evaluator out of the function scope.

Changed 9 years ago by Frederico Caldeira Knabben

Attachment: 4781_6.patch added

comment:10 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review? added; Review- removed

comment:11 Changed 9 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:12 Changed 9 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with #4734.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy