Opened 6 years ago

Closed 6 years ago

#4795 closed Bug (fixed)

[IE] Deleting focused horizontal line/table by DEL key generates javascript error

Reported by: pomu0325 Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.2
Component: General Version: 3.0.1
Keywords: Confirmed IE Review+ Cc: pomu@…

Description

To Reproduce

  • Open sample page with IE
  • Click HR button from toolbar
  • Press 'Delete' key
  • Error occurs on line.210 of selection/plugin.js

Attachments (2)

4795.patch (1.7 KB) - added by pomu0325 6 years ago.
workaroung patch for IE8Compat mode
4795_2.patch (1.8 KB) - added by garry.yao 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by pomu0325

  • Summary changed from [IE] Deleting horizontal line generates javascript error to [IE] Deleting horizontal line/table generates javascript error

Deleting focused table by 'Delele' key also generates same error.

comment:2 follow-up: Changed 6 years ago by fredck

  • Keywords Confirmed IE added
  • Milestone set to CKEditor 3.2

Confirmed with IE8. (The HR must be selected first)

comment:3 in reply to: ↑ 2 Changed 6 years ago by pomu0325

  • Summary changed from [IE] Deleting horizontal line/table generates javascript error to [IE] Deleting focused horizontal line/table by DEL key generates javascript error

Replying to fredck:

Confirmed with IE8. (The HR must be selected first)

Sorry, select step was missing.

comment:4 Changed 6 years ago by pomu0325

I found out that IE8 hide focus after removing "Control" type object (such as table, horizontal line). So I wrote a workaround to move caret to the next element.

Changed 6 years ago by pomu0325

workaroung patch for IE8Compat mode

Changed 6 years ago by garry.yao

comment:5 Changed 6 years ago by garry.yao

  • Keywords Review? added
  • Owner set to garry.yao
  • Status changed from new to assigned

Providing a simplified patch inspired by pomu's idea.

comment:6 Changed 6 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:7 Changed 6 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [5010].

Note: See TracTickets for help on using tickets.
© 2003 – 2015 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy