Opened 8 years ago

Closed 7 years ago

#4795 closed Bug (fixed)

[IE] Deleting focused horizontal line/table by DEL key generates javascript error

Reported by: pomu0325 Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.2
Component: General Version: 3.0.1
Keywords: Confirmed IE Review+ Cc: pomu@…

Description

To Reproduce

  • Open sample page with IE
  • Click HR button from toolbar
  • Press 'Delete' key
  • Error occurs on line.210 of selection/plugin.js

Attachments (2)

4795.patch (1.7 KB) - added by pomu0325 8 years ago.
workaroung patch for IE8Compat mode
4795_2.patch (1.8 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 8 years ago by pomu0325

Summary: [IE] Deleting horizontal line generates javascript error[IE] Deleting horizontal line/table generates javascript error

Deleting focused table by 'Delele' key also generates same error.

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Confirmed IE added
Milestone: CKEditor 3.2

Confirmed with IE8. (The HR must be selected first)

comment:3 in reply to:  2 Changed 8 years ago by pomu0325

Summary: [IE] Deleting horizontal line/table generates javascript error[IE] Deleting focused horizontal line/table by DEL key generates javascript error

Replying to fredck:

Confirmed with IE8. (The HR must be selected first)

Sorry, select step was missing.

comment:4 Changed 8 years ago by pomu0325

I found out that IE8 hide focus after removing "Control" type object (such as table, horizontal line). So I wrote a workaround to move caret to the next element.

Changed 8 years ago by pomu0325

Attachment: 4795.patch added

workaroung patch for IE8Compat mode

Changed 7 years ago by Garry Yao

Attachment: 4795_2.patch added

comment:5 Changed 7 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

Providing a simplified patch inspired by pomu's idea.

comment:6 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:7 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [5010].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy