Opened 10 years ago

Closed 10 years ago

#4810 closed New Feature (fixed)

Text change request for image properties dialog preview label

Reported by: Russ Tennant Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Dialogs Version: 3.0.1
Keywords: IBM Confirmed Review+ Cc: Damian, Joe Kavanagh

Description

Image Properties Dialog / Image Info tab

We've received requests from users to change the label "Preview" to something else. The users are confused by the "Lorem Ipsum" text. They think the text is going to be inserted when they click OK. One suggestion for a different label is "Image Preview and Placeholder Text".

Attachments (1)

4810.patch (3.4 KB) - added by Garry Yao 10 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added
Milestone: CKEditor 3.3

Let's make it configurable.

comment:2 Changed 10 years ago by Alfonso Martínez de Lizarrondo

The label can be adjusted now with editor.lang.image.preview. The Lorem Ipsum text doesn't work the same way, but adding an Id I think that it must be possible. At least that's my idea with the easyUpload plugin but I still haven't tested it.

I'll verify that it works and I'll explain how to do it.

comment:3 Changed 10 years ago by Alfonso Martínez de Lizarrondo

I think that just adding the id (that it's needed for the ability to remove the preview) will be enough: http://alfonsoml.blogspot.com/2009/12/adjusting-preview-text-in-easyupload.html

comment:4 Changed 10 years ago by Russ Tennant

That's great. Thanks.

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

@alfonsoml, the article illustrates it well thanks!

Just to clarify, when I talk about making it configurable, I mean having a "documentation only" setting (no code definition for it) which, if defined sets the text to be used there, otherwise we use the default Lorem Ipsum. It will have almost no code impact, and will touch the dialog file only.

comment:6 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Cc: Damian Joe Kavanagh added
Keywords: IBM added

#5076 has been marked as dup

comment:7 Changed 10 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

Changed 10 years ago by Garry Yao

Attachment: 4810.patch added

comment:8 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review+ added; Review? removed

Change the type in the documentation from boolean to string.

comment:9 Changed 10 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [5233].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy