Opened 8 years ago

Closed 8 years ago

#4812 closed Bug (fixed)

'Esc' key is not working for dialog on Opera

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.1
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: Confirmed 3.0.2 Opera Review+ Cc:

Description

Press 'Esc' doesn't close the dialog in all dialogs on Opera.

Attachments (2)

4812.patch (3.1 KB) - added by Garry Yao 8 years ago.
4812_2.patch (1.8 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Garry Yao

Attachment: 4812.patch added

comment:1 Changed 8 years ago by Garry Yao

Keywords: Confirmed Review? added
Owner: set to Garry Yao
Status: newassigned

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The ESC key stopped working with Firefox after the patch.

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Actually, it stopped working just in a specific case, and not only in FF but also with IE:

  1. Open the Link dialog.
  2. Hit SHIFT+TAB to focus the "Protocol" combo.
  3. Hit ESC. It will not work.

This happens with all combos in dialogs.

Changed 8 years ago by Garry Yao

Attachment: 4812_2.patch added

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review- removed

Looks good. I just think we should not make changes to Gecko+Mac without confirming that we have the issue there. Please remove it before committing.

comment:5 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [4735].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy