Opened 8 years ago

Closed 8 years ago

#4932 closed Bug (fixed)

Collapse toolbar button visible but not usable on simple toolbars

Reported by: Wiktor Walc Owned by: Minh Nguyen
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Toolbar Version: SVN (CKEditor) - OLD
Keywords: IBM Oracle Confirmed Review+ Cc: Pranav, Senthil, lisaj, Joe Kavanagh, Damian

Description

When using simple toolbar, like in the uicolor sample, there is a "collapse toolbar" arrow on the right side of the toolbar. Clicking on it does nothing.

Apparently it works when there are at least two rows of buttons. I think it could be hidden automatically when there is only one row of buttons.

Attachments (4)

4932.patch (1.2 KB) - added by Minh Nguyen 8 years ago.
4932_2.patch (1.3 KB) - added by Minh Nguyen 8 years ago.
4932_3.patch (1.6 KB) - added by Minh Nguyen 8 years ago.
4932_4.patch (1.7 KB) - added by Minh Nguyen 8 years ago.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Cc: Pranav Senthil lisaj added
Keywords: Oracle added
Milestone: CKEditor 3.3
Type: New FeatureBug
Version: 3.1

#5097 and #5037 have been marked as dups.

If people want to hide the collapse button they can do it in the configuration, but if they have left it enabled then it should work, so this is a bug.

comment:2 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Cc: Joe Kavanagh Damian added
Keywords: IBM added

#5227 has been marked as dup

Changed 8 years ago by Minh Nguyen

Attachment: 4932.patch added

comment:3 Changed 8 years ago by Minh Nguyen

Keywords: Review? added
Owner: set to Minh Nguyen
Status: newassigned

Changed 8 years ago by Minh Nguyen

Attachment: 4932_2.patch added

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.3
Resolution: worksforme
Status: assignedclosed

This one is working for me now with CKEditor 3.2.

comment:5 Changed 8 years ago by Minh Nguyen

Resolution: worksforme
Status: closedreopened
Version: 3.1SVN (CKEditor)

#5251 has been marked as dup This bug still happen with simple toolbar on Chrome, Safari, Opera.

comment:6 Changed 8 years ago by Minh Nguyen

Keywords: IBM Oracle Confirmed Review?IBM Oracle Confirmed Review? Review?
Milestone: CKEditor 3.3

comment:7 Changed 8 years ago by Minh Nguyen

Keywords: IBM Oracle Confirmed Review? Review?IBM Oracle Confirmed Review?

comment:8 Changed 8 years ago by Garry Yao

How about 'min-height:1' just save couple of bytes more?

comment:9 Changed 8 years ago by Garry Yao

Keywords: Review- added; Review? removed

Note that a [http://dev.fckeditor.net/browser/CKEditor/trunk/_source/skins/kama/toolbar.css#L416

previous fix] is already created for FF, it should be normalized as well.

Changed 8 years ago by Minh Nguyen

Attachment: 4932_3.patch added

comment:10 Changed 8 years ago by Minh Nguyen

Keywords: Review? added; Review- removed

comment:11 Changed 8 years ago by Garry Yao

Could you tell me why the targeting browsers various in different skin files in 4932_3.patch?

comment:12 Changed 8 years ago by Minh Nguyen

Sorry, I didn't clear browser's cache when test it.

This bug happen when toolbar's offsetHeight always is zero in case it has one row of buttons. Then we check isVisible at line http://dev.fckeditor.net/browser/CKEditor/trunk/_source/core/dom/element.js#L759 return false value.

Changed 8 years ago by Minh Nguyen

Attachment: 4932_4.patch added

comment:13 Changed 8 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:14 Changed 8 years ago by Minh Nguyen

Resolution: fixed
Status: reopenedclosed

Fixed with [5216].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy