Opened 8 years ago

Closed 8 years ago

#4940 closed Bug (fixed)

Setting config.customConfig = '' doesn't work

Reported by: Alfonso Martínez de Lizarrondo Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc:

Description

According to the docs of customConfig that's the way to avoid an extra request for the config file if it isn't needed, but the code in core/editor.js uses it this way:

	var loadConfig = function( editor )
	{
		var customConfig = CKEDITOR.getUrl( editor.config.customConfig );

		// Check if there is a custom config to load.
		if ( !customConfig )
			return false;

and the call to CKEDITOR.getUrl() returns the base url of CKEditor, so the return false isn't executed.

For this specific problem the "if ( !customConfig )" can be moved before the getUrl call, but maybe it would be better to change that function so it doesn't alter empty strings.

Attachments (1)

4940.patch (730 bytes) - added by Frederico Caldeira Knabben 8 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Confirmed added
Milestone: CKEditor 3.1
Version: SVN (CKEditor)

Regression introduced with [4585].

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Owner: set to Frederico Caldeira Knabben
Status: newassigned

Changed 8 years ago by Frederico Caldeira Knabben

Attachment: 4940.patch added

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review? added

comment:4 Changed 8 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: assignedclosed

Fixed with [4871].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy