Opened 10 years ago

Closed 10 years ago

#4950 closed Bug (fixed)

Creating centered list is a bit troublesome

Reported by: Wiktor Walc Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.3
Component: Core : Lists Version: 3.0
Keywords: Confirmed Review+ Cc: Martin Kou

Description

Tested and confirmed in IE8, FF 3.5, Safari 4.

Steps to reproduce

  • start with the following source:
    <ul>
    	<li>
    		aaa</li>
    	<li>
    		bbb</li>
    	<li>
    		ccc</li>
    </ul>
    
  • press Ctrl + A and hit "Center Justify" button
  • click at the end of last element and hit enter twice to exit from the list
  • result: list is not centered anymore.

this bug does not occur in FCKeditor.

Attachments (1)

4950.patch (3.2 KB) - added by Garry Yao 10 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.3

That's weird.

comment:2 Changed 10 years ago by Garry Yao

Considering the facts that:

  1. Alignment style could only be applied on the list item;
  2. The list system destroys all list items style when transforming.

So it's not a surprise to have see this kind of result.

comment:3 Changed 10 years ago by Garry Yao

Component: GeneralCore : Lists
Owner: set to Garry Yao
Status: newassigned

this bug does not occur in FCKeditor.

In v3, we're using an [http://dev.fckeditor.net/browser/CKEditor/trunk/_source/plugins/enterkey/plugin.js#L85

innovative] way that uses outdent for 'exit enter'. Same bug happen in v2 if you replace the 3rd step in above TC with outdent command.

Changed 10 years ago by Garry Yao

Attachment: 4950.patch added

comment:4 Changed 10 years ago by Garry Yao

Cc: Martin Kou added
Keywords: Review? added

Proposing an unobtrusive way to handle DOM nodes in arrayToList and listToArray, I pray that Martin could saw this patch and conduct the review ;)

comment:5 Changed 10 years ago by Garry Yao

Ticket Test added:
run OR view source.

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:7 Changed 10 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [5285].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy