Opened 8 years ago

Closed 8 years ago

#5018 closed Bug (fixed)

Find highlighter removes bgcolor and font color from words

Reported by: Damian Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.3
Component: Core : Styles Version: SVN (CKEditor) - OLD
Keywords: IBM Confirmed Review+ Cc: Joe Kavanagh

Description

  1. Open the CK Editor.
  2. Apply text colour or background colour to a word.
  3. Click on find icon
  4. Search for the word from step 2.
  5. See that the word gets highlighted
  6. Click on cancel button to close the find and replace light box

Actual result: the text colour or background colour that you have applied to the word is removed.

Expected result: the text colour or back ground colour applied to the word should remain

Attachments (4)

5018.patch (753 bytes) - added by Garry Yao 8 years ago.
5018_2.patch (802 bytes) - added by Garry Yao 8 years ago.
5018_3.patch (1.8 KB) - added by Garry Yao 8 years ago.
5018_4.patch (2.4 KB) - added by Garry Yao 8 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 8 years ago by Garry Yao

Component: GeneralCore : Styles
Keywords: Confirmed added
Owner: set to Garry Yao
Status: newassigned
Version: SVN (CKEditor)

Nice catch!

Changed 8 years ago by Garry Yao

Attachment: 5018.patch added

comment:2 Changed 8 years ago by Garry Yao

Keywords: Review? added

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Instead of setting the childRule in the configuration option, let's have it hardcoded (when loading find_highlight), making the settings simpler, avoiding errors by third developers and also making the fix backwards compatible with custom configuration files.

Changed 8 years ago by Garry Yao

Attachment: 5018_2.patch added

comment:4 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

I've tested the patch with the ticket TC and it's still not working.

Changed 8 years ago by Garry Yao

Attachment: 5018_3.patch added

comment:6 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

Proposing of a new approach.

comment:7 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
  1. In FF, load the following HTML:
<p>You <span style="background-color: rgb(0, 255, 0);">are</span> using CKEditor.</p>
  1. Open the Find dialog.
  2. Find the word "are". Note that the word is not properly highlighted.
  3. Click "Cancel" to close the dialog.

The word "are" doesn't loose the background, but now it's foreground color is white (almost) and the source shows the following:

<p>You <span style="background-color: rgb(0, 0, 68); color: rgb(255, 255, 255);"><span style="background-color: rgb(0, 255, 0);">are</span></span> using CKEditor.</p>

The source output should instead remain untouched.

Also, if you'll be still proposing that additional property in the style definition, please rename it to "fullMatch". "unique" doesn't tell us much.

Changed 8 years ago by Garry Yao

Attachment: 5018_4.patch added

comment:8 Changed 8 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:9 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:10 Changed 8 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed

Fixed with [5290].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy