#5099 closed Bug (fixed)
Smiley path configuration property not producing relative emiticon links
| Reported by: | Joe Kavanagh | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.3 |
| Component: | General | Version: | SVN (CKEditor) - OLD |
| Keywords: | IBM Confirmed Review+ | Cc: | dchojna@… |
Description
- Update you config.js to include config.smiley_path ='/plugins/sametimeemoticons/images/';
- Create an instance of the editor and insert a smiley.
- Click the Source button to enter HTML mode
Observe the the image src attribute values are not relative URLs.
Relative URLs were being used in version 3.0.1 when you set smiley_path.
Attachments (1)
Change History (13)
comment:1 Changed 16 years ago by
| Milestone: | → CKEditor 3.2 |
|---|
comment:2 Changed 16 years ago by
| Keywords: | Pending WorksForMe added |
|---|---|
| Priority: | High → Normal |
comment:3 Changed 16 years ago by
| Milestone: | CKEditor 3.2 |
|---|---|
| Resolution: | → worksforme |
| Status: | new → closed |
WFM also. Please feel free to reopen the ticket if you have more information about it.
comment:4 Changed 16 years ago by
| Resolution: | worksforme |
|---|---|
| Status: | closed → reopened |
| Summary: | Smiley path configuration property not producing relative emiticon links → CKEDITOR_BASEPATH has no affect on CKEDITOR.basePath. |
I've investigated this further. Setting the global variable CKEDITOR_BASEPATH has no affect on CKEDITOR.basePath.
In this case smiley_path was set to CKEDITOR.basePath + '/plugins/smiley/images'.
comment:5 Changed 16 years ago by
| Keywords: | Confirmed added; Pending WorksForMe removed |
|---|---|
| Milestone: | → CKEditor 3.3 |
| Summary: | CKEDITOR_BASEPATH has no affect on CKEDITOR.basePath. → Smiley path configuration property not producing relative emiticon links |
Ok, I've opened a dedicated ticket for it to not make this one confusing.
In any case, we should use CKEDITOR.getUrl() in this configuration option, not CKEDITOR.basePath directly. I'm leaving this ticket opened so we can fix it.
Changed 16 years ago by
| Attachment: | 5099.patch added |
|---|
comment:6 Changed 16 years ago by
| Keywords: | Review? added |
|---|
comment:7 Changed 16 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | reopened → new |
comment:8 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:10 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:11 Changed 15 years ago by
I'm getting this in 3.3.1, should I reopen this one or start a new ticket? I checked and the patch above had already been incorporated into _source/plugin/smiley/plugin.js
comment:12 Changed 15 years ago by
Please open a new ticket with full details about the issue. Thanks.
I've tested Firefox 3.6, Chrome 4, IE 8 and Opera 10.10 and it's working fine in all of them.