Opened 15 years ago
Closed 11 years ago
#5138 closed Bug (wontfix)
Naming convention mistakes in dialogs' tabs
Reported by: | Sa'ar Zac Elias | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | UI : Dialogs | Version: | 3.1 |
Keywords: | Cc: |
Description
Some dialogs have naming convention mistakes in the tabs - these might confuse the developer.
in my opinion it's for the best that all tab names will be lowercase and using toLowerCase() in dialog definition events when trying to remove or get tabs.
a list of what i've fond:
- 'advanced' in all dialogs
- 'info' in all dialogs
- 'find' & 'replace' in find dialog
- 'properties' in flash dialog
- 'target' & 'upload' in link dialog
- 'options', 'langs', 'ditionaries' & 'about' in SCAYT dialog
Some more mistakes, yet minor since it is the only tab there:
- 'tab1' in about, smiley & uicolor dialogs
- 'general' in clipboard, pasetext & wsc dialogs
- 'picker' in color dialog
- 'selectTpl' in template dialog
Change History (3)
comment:1 Changed 14 years ago by
Milestone: | → CKEditor 3.5.1 |
---|---|
Status: | new → confirmed |
comment:2 Changed 14 years ago by
Milestone: | CKEditor 3.5.1 |
---|---|
Status: | confirmed → pending |
I can't see this a problem and seeing unnecessary to reinforce lowercase unless our codes are affected by this problem somewhere, it's more a user preference of the dialog field identifier.
comment:3 Changed 11 years ago by
Resolution: | → wontfix |
---|---|
Status: | pending → closed |
This indeed is not a good practise that we don't have a standard naming convention. However, it is now impossible to change those names, because of backward compatibility.
This is now in priority because of #5915.
Let's make the configuration introduced with #5915 case insensitive.
Note that we must keep backwards compatibility regarding changes of this ticket'''