Opened 9 years ago

Closed 6 years ago

Last modified 6 years ago

#5189 closed Bug (fixed)

Find/Replace dialog: rename button to "Close"

Reported by: Frederico Caldeira Knabben Owned by: Piotr Jasiun
Priority: Normal Milestone: CKEditor 4.1.3
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: Discussion Cc: mattleff@…

Description

In the Find/Replace dialog, the button should be labeled "Close" and not "Cancel", because it doesn't really cancels the replacement operation.

Change History (10)

comment:1 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

Milestone CKEditor 3.x deleted

comment:2 Changed 7 years ago by Matthew Leffler

Cc: mattleff@… added

@fredck My team has noticed this inconsistency as well. Could we get this targeted for CKEditor 4?

comment:3 Changed 6 years ago by Matthew Leffler

I've added a pull request for this: https://github.com/ckeditor/ckeditor-dev/pull/28.

comment:4 Changed 6 years ago by Jakub Ś

Status: newconfirmed

comment:5 Changed 6 years ago by Piotr Jasiun

Owner: set to Piotr Jasiun
Status: confirmedassigned

comment:6 Changed 6 years ago by Piotr Jasiun

Milestone: CKEditor 4.1.3

comment:7 Changed 6 years ago by Piotr Jasiun

Status: assignedreview

Pulled and modified. There is one unit test for this.

comment:8 Changed 6 years ago by Olek Nowodziński

Status: reviewreview_passed

Here you go:

  • Rebased both branches on latest master.
  • Fixed code style both in t/5189 and tests.
  • Discarded ambiguous button label test. This is a really minor change and doesn't need to be covered by tests. Additionally tests shouldn't depend on any particular translation or lang file.

Please don't forget about proper change log entry masterizing the branch.

comment:9 Changed 6 years ago by Piotr Jasiun

Resolution: fixed
Status: review_passedclosed

comment:10 Changed 6 years ago by Piotr Jasiun

Fixed with git:280baad

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy