Fail to load in IE if FCKConfig.ToolbarSets has a trailing comma

[Alfonso Martínez de Lizarrondo]

If the user customizes the toolbarset and leaves a trailing comma then IE will fail to load the editor.

It can be fixed with

editor/_source/internals/fcktoolbarset.js

@@ -242 +242 @@
 
                 var oToolbar ;
 
+                if ( typeof( oToolbarItems ) == 'undefined' )
+                        continue ;
+
                 if ( typeof( oToolbarItems ) == 'string' )
                 {
                         if ( oToolbarItems == '/' )

Is it worth?

I ask this question because people having this problem surely haven't read anything about how to customize the editor, and they should.

(And yes, I wanted to test how to put a patch right here ;-) )

[Frederico Caldeira Knabben]

Nice move Alfonso. Let's help the lazy developers out there.

It can be even simpler, comprehending also cases where, by some coding magic, it returns "null":

editor/_source/internals/fcktoolbarset.js

@@ -239 +239 @@
         for ( var x = 0 ; x < ToolbarSet.length ; x++ )
         {
                 var oToolbarItems = ToolbarSet[x] ;
+                
+                if ( !oToolbarItems ) 
+                        continue ; 
 
                 var oToolbar ;
 

If you feel ok with it, go ahead committing it.

(And yes, I wanted to test how to put a patch right here ;-) )

I understood it as soon as I saw your ticket :))

[Alfonso Martínez de Lizarrondo]

Fixed with [345]