Opened 15 years ago
Closed 15 years ago
#5274 closed Bug (fixed)
[[IE6]] Content Templates dialog is not displaying properly
| Reported by: | Satya Minnekanti | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.3 |
| Component: | UI : Dialogs | Version: | SVN (CKEditor) - OLD |
| Keywords: | IE IBM Confirmed Review+ | Cc: | joek, Damian |
Description
To reproduce the defect
- open ajax sample and click on Templates option.
- Look at the Content Templates dialog.
In FF the dialog looks proper with Templates Options.
In IE 6 the dialog and the Options are not displayying properly.
I have attached a screenshot to show the differenced between FF & IE6
Attachments (9)
Change History (26)
Changed 15 years ago by
| Attachment: | Templates dialog in FF3.jpg added |
|---|
Changed 15 years ago by
| Attachment: | Templates dialog in IE6.jpg added |
|---|
comment:1 Changed 15 years ago by
| Component: | General → UI : Dialogs |
|---|---|
| Milestone: | → CKEditor 3.3 |
Changed 15 years ago by
| Attachment: | 5274.patch added |
|---|
comment:2 Changed 15 years ago by
| Keywords: | IE Confirmed Review? added |
|---|---|
| Owner: | set to Garry Yao |
| Status: | new → assigned |
| Version: | → SVN (CKEditor) |
comment:3 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
The problem with the patch is that now all the preview images are resized to 100x70. If it's not possible to find another fix for the IE6 problem, I would propose to adjust the changes so this restriction is placed only for IE6 and the rest of browsers can see the images at their correct dimensions.
comment:4 Changed 15 years ago by
| Cc: | joek Damian Frederico Caldeira Knabben added; joek damo removed |
|---|---|
| Keywords: | Review? added; Review- removed |
I assume that all preview images should be chromed as a fixed size?
comment:5 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
No, we should not force the image size.
Changed 15 years ago by
| Attachment: | 5274_2.patch added |
|---|
comment:6 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:7 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
I just feel that a simpler solution can be found.
Can you confirm that it can be fixed by simply adding onload="this.width=this.width" to the <img> tags? I made some quick tests here and it seems to work. If it works, please provide a new patch with it.
Changed 15 years ago by
| Attachment: | 5274_3.patch added |
|---|
comment:9 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Please add a space before "onload".
comment:11 Changed 15 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Now the Template options are displaying properly in IE6 but the Background colour that surrounds the option when we move through the option is not shown in IE6..it is shown in all other browsers..I am attaching a screen shots to show the differences
Changed 15 years ago by
| Attachment: | Template Options in IE6 with out BackgroundColor.jpg added |
|---|
Changed 15 years ago by
| Attachment: | Template Options in FF with BackgroundColor.jpg added |
|---|
Changed 15 years ago by
| Attachment: | 5274_4.patch added |
|---|
comment:12 Changed 15 years ago by
| Keywords: | Review? added; Review+ removed |
|---|
comment:13 Changed 15 years ago by
@satya, please open new tickets instead of reopening tickets that have already been closed, even if they look related.
comment:14 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
The background-position trick is really weird (just like IE6), but it works (unlike IE6).
My only concern is regarding the pointer change. I know you wanted to separate the IE6 ugly stuff from the rest, but by doing this we maybe just make the CSS files bigger, having the IE6 impact even more drastic. Couldn't we just change "inherit to hand in the "Fix" declaration that we have a few lines after the patch changes?
Changed 15 years ago by
| Attachment: | 5274_5.patch added |
|---|
comment:15 Changed 15 years ago by
| Cc: | Frederico Caldeira Knabben removed |
|---|---|
| Keywords: | Review? added; Review- removed |
I know you wanted to separate the IE6 ugly stuff from the rest...
Actually I wasn't aware of the previous fix at all.
comment:16 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Avoid template item size depending on preview image.