Opened 8 years ago

Closed 5 years ago

#5339 closed Bug (expired)

In fullpage mode, document without "title" tag breaks CKEditor

Reported by: Ben Houston Owned by: Minh Nguyen
Priority: Normal Milestone:
Component: General Version: 3.2
Keywords: HasPatch Cc:

Description

To reproduce:

  1. create an editor with the "fullpage" option turned on.
  1. start editing content in WYSIWYG mode.
  1. switch to source mode and adjust the content so that there is no title tag in the head.
  1. switch back to WYSIWYG mode, note that the toolbar buttons don't come back to being usable.

Patch:

Patch for plugins/wysiwygarea/plugin.js (at least, here's the diff that fixes it for us):

741,744c741,742
<                                         if (title != null) {
< 						title.setAttribute( '_cke_title', editor.document.$.title );
< 						editor.document.$.title = frameLabel;
<                                         }
---
> 					title.setAttribute( '_cke_title', editor.document.$.title );
> 					editor.document.$.title = frameLabel;

Attachments (1)

5339.patch (530 bytes) - added by Minh Nguyen 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Keywords: HasPatch added; fullpage removed

Changed 8 years ago by Minh Nguyen

Attachment: 5339.patch added

comment:2 Changed 8 years ago by Minh Nguyen

Keywords: Review? added
Owner: set to Minh Nguyen
Status: newassigned

comment:3 Changed 8 years ago by Matti Järvinen

Related #5338 ?

comment:4 Changed 7 years ago by Wiktor Walc

Keywords: HasPatch added; HasPatch? removed
Status: reviewassigned

comment:5 Changed 7 years ago by Wiktor Walc

Status: assignedpending

Works for me in trunk.

comment:6 Changed 5 years ago by Jakub Ś

Resolution: expired
Status: pendingclosed

WFM as well.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy