Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#5365 closed Task (wontfix)

Undocumented options for the link dialog

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone:
Component: QA Version: 3.2
Keywords: Discussion Review- Cc:

Description

In link\plugin.js there are two options that aren't documented

CKEDITOR.tools.extend( CKEDITOR.config,
{
	linkShowAdvancedTab : true,
	linkShowTargetTab : true
} );

As the new architecture of the dialogs allow to easily customize the tabs of each dialog, I wonder if we should add the documentation for these or just remove them (and the little code in the dialog.js file)

Personally, I vote for removing them. Note also that the image plugin lacks the corresponding options.

Attachments (1)

5365.patch (1.2 KB) - added by Alfonso Martínez de Lizarrondo 10 years ago.
Proposed patch

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by Alfonso Martínez de Lizarrondo

Attachment: 5365.patch added

Proposed patch

comment:1 Changed 10 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added
Milestone: CKEditor 3.3
Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned

I've included in http://docs.cksource.com/CKEditor_3.x/Developers_Guide/Dialog_Customization a function explaining how to get all the missing options regarding to the dialogs, so these options now can be removed.

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
Milestone: CKEditor 3.3CKEditor 3.x
Resolution: wontfix
Status: assignedclosed

I can't tell you if people are using these setting or not (we had the same setting on FCKeditor), but considering that we've had them for a long time, I would just leave it as is, even without documentation. Let's remove them on version 4.

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

comment:4 Changed 9 years ago by Wiktor Walc

I'm not really sure about whether removing those configuration options is really a good idea. Configuration setting is something easy to use, using even a ready snippet of strange JavaScript code is just a nightmare for less advanced users.

comment:5 Changed 9 years ago by Alfonso Martínez de Lizarrondo

For me the problem with the previous options is that they are limited to some of the dialogs (ok, currently all that have tabs), and just to the tabs themselves.

That doesn't cover the Properties tab in the Flash dialog or the new tab that might be introduced in the Table dialog to specify id, style and class. So with every such change we have to keep introducing new config options.

And of course, that doesn't allow to remove individual items inside the tabs, so I think that providing good documentation and examples might be the better for the long term. We can even think about additional options to specify how to remove options that takes care of the javascript function and the user just have to provide some object or string specifying what he wants to remove.

In the end the user has to read the docs to find how to do that he wants, so if the docs specify how to do it for any dialog we can save a lot of time because we don't have to worry about keeping the config options updated with every change to the dialogs, or saying: "to remove tabs: use the config options"; "to remove elements: use this javascript."

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy