Opened 15 years ago
Closed 14 years ago
#5439 closed Bug (worksforme)
Unable to align selected text in a table
Reported by: | Wiktor Walc | Owned by: | Sa'ar Zac Elias |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | General | Version: | 3.0.2 |
Keywords: | Cc: |
Description
The alignment options do not work inside of a table cell if the content (text, image) is selected. Confirmed in FF 3.6.2 and IE 8. It was working correctly until 3.0.1.
Steps to repoduce
- Start with the following source
<table border="1" cellpadding="1" cellspacing="1" style="width: 600px"> <tbody> <tr> <td> one</td> <td> two</td> </tr> <tr> <td> three</td> <td> four</td> </tr> </tbody> </table>
- Switch to wysiwyg mode, select "one"
- Click on the "Right Justify" button
- result: text is not aligned to the right.
Attachments (1)
Change History (9)
comment:1 Changed 15 years ago by
Milestone: | → CKEditor 3.4 |
---|
comment:2 Changed 15 years ago by
Owner: | set to brooks |
---|---|
Status: | new → assigned |
comment:3 Changed 14 years ago by
Owner: | brooks deleted |
---|---|
Status: | assigned → new |
Changed 14 years ago by
Attachment: | 5439.patch added |
---|
comment:4 Changed 14 years ago by
Owner: | set to Sa'ar Zac Elias |
---|---|
Status: | new → assigned |
comment:5 Changed 14 years ago by
Keywords: | Review? added |
---|
comment:6 Changed 14 years ago by
Status: | review → review_failed |
---|
It's the job of the iterator to retrieve the proper paragraph on first call. It looked strange the change to simply take the startContainer, and I was able to easily prove why it's wrong with this:
- Load this HTML:
<p><strong>Some bold text</strong></p>
- Select the word "bold".
- Click the "right align" button.
In the source view, you can notice that the <strong> element got the "text-align: right;" style, which is wrong.
The thing to be fixed is being sure that getNextParagraph() will return the right thing in that case.
comment:7 Changed 14 years ago by
Keywords: | Confirmed removed |
---|
I can no longer reproduce the bug on trunk.
comment:8 Changed 14 years ago by
Milestone: | CKEditor 3.4 |
---|---|
Resolution: | → worksforme |
Status: | review_failed → closed |
Yes, it's working well now on trunk.
confirmed in Firefox & IE & Chrome