Opened 15 years ago
Closed 15 years ago
#5450 closed Bug (fixed)
Press enter on 'replace' button result wrong
Reported by: | Garry Yao | Owned by: | brooks |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.3 |
Component: | UI : Dialogs | Version: | |
Keywords: | Review+ | Cc: |
Description
Reproducing Procedures
- Load the any of the sample page;
- Open 'Replace' dialog and fill in 'are';
- Tab to focus the 'Replace All' button and press 'Enter';
- Expected Result: You get only the success message.
- Actual Result: You get both message: 'Specified text not found' and '1 occurance replaced'.
Attachments (3)
Change History (11)
comment:1 Changed 15 years ago by
Owner: | set to brooks |
---|---|
Status: | new → assigned |
Changed 15 years ago by
Attachment: | 5450.patch added |
---|
comment:2 Changed 15 years ago by
Keywords: | Review? added; Confirmed removed |
---|
comment:3 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
this bug only happen in firefox, it's a weired behavior
It's indeed a Firefox bug, I believe the default event behavior is somehow affected by the focus (alert box grab the focus from button). While the real problem is that the [http://dev.fckeditor.net/browser/CKEditor/trunk/_source/plugins/dialogui/plugin.js#L507
click simulating logics] are not needed at all, since most major browsers and assistive technologies trigger onClick if the Enter key is pressed when the link has focus.
Changed 15 years ago by
Attachment: | 5450_2.patch added |
---|
comment:4 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
yes, in firefox, when a link is focused and then hit enter key, it will fire click event and couldn't be prevent.
comment:5 Changed 15 years ago by
Keywords: | Review- added; Review? removed |
---|
It's not a FF only behavior, actual all browsers agree with it on link, and our buttons are all made of link, so IMO we just need to remove the enterkey delegation in all places:
if ( evt.data.getKeystroke() in { 32:1 } )
Changed 15 years ago by
Attachment: | 5450_3.patch added |
---|
comment:6 Changed 15 years ago by
Keywords: | Review? added; Review- removed |
---|
the FF only behavior is that when a link is focused,the enterkey delegation couldn't be prevented,but other browsers could.
of course,it's a nice idea not to listen the keydown event for enter key in this case, 'cause the click event will always fired when hit a focused link.
comment:7 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
Please remove the extra spaces on committing.
comment:8 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
fixed with 5402 5402
this bug only happen in firefox, it's a weired behavior
when debugger, e.g, add break point in source code, u can't reproduce the bug
I trace to here:
_source/plugins/dialogui/plugin.js#503
then found when hit enter,the click event fired too.