we can't remove the format of the copied & pasted text by selecting the text and clicking on Formatted icon

[Satya Minnekanti]

To reproduce the defect:

1. Open Ajax sample.

2. Type few lines of text.

3. Apply Bold Formatting to the text in the First line.

4. Copy the Formatted text in the first line and Paste it at the end of last line.

5. Select the Pasted text and see that the Bold icon in Toolbar is highlighted.

6. Click on Bold Icon.

Expected Result:

Bold Format applied to the text is removed

Actual Result:

Bold Format applied to the text is not removed.

We can remove the format using only the following two ways.

Go to HTML Source and Come back to WYSIWYG mode and select the text again and click Bold icon or

Select the Pasted text and Click on Remove Format Icon.

Same behaviour happens with Italic,Underline,Strike Through,Subscript and Superscript formatting options.

Tested against FF3,IE 6&7

[Frederico Caldeira Knabben]

Confirmed with CKEditor 3.0.

[brooks]

only reproduceable in FF

[brooks]

pls just review for 5455_3.patch

[Garry Yao]

The patch doesn't work when both attributes present on element.

On the other hands, I think our styles system is doing wrong in this sense, though we have kept it for a long time since v2, e.g. user put a class attribute on the strong element could easily break the style removing, which doesn't make sense.

[Garry Yao]

Proposing a solution to have it discussed.

[Frederico Caldeira Knabben]

The proposed approach is wrong, because now we'll leave an empty <span> when removing the bold formatting, just because of the presence of the _cke_expando attribute.

We need to check where we're using element.hasAttributes(), but maybe we can make it ignore the _cke_expando attribute. In that case the change would be much simpler and safer.

[Sa'ar Zac Elias]

The patch makes the hasAttributes method to ignore the _moz_dirty attribute, as well as adds Garry's solution.

[Frederico Caldeira Knabben]

Having or not to handle removal of styles partially valid for the selection, replacing them with <span>, is something out of the scope of this ticket, and needs discussions, together with a real world test case.

[Frederico Caldeira Knabben]

KISS

[Sa'ar Zac Elias]

Filed #6026 to discuss Garry's proposal.

[Frederico Caldeira Knabben]

Fixed with [5741].