Opened 7 years ago

Closed 7 years ago

#5487 closed Bug (fixed)

Fullpage writer problem with line-break

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.4.1
Component: General Version:
Keywords: Cc:

Description (last modified by Garry Yao)

Environment

All IE versions.

Reproducing Procedures

  1. Load the 'Full Page Support' sample page;
  2. Press 'Enter' key at the end of the first paragraph to create a new empty line;
  3. Switch to source mode:
  • Actual Result:
    <html>
    	<head>
    		<title>CKEditor Sample</title>
    	</head>
    	<body>
    		<p>
    			...</p></body>
    </html>
    
  • Expected Result: There's a line break before closing </body>
    <html>
    	<head>
    		<title>CKEditor Sample</title>
    	</head>
    	<body>
    		<p>
    			...</p>
           </body>
    </html>
    

Attachments (2)

5487.patch (1.2 KB) - added by Garry Yao 7 years ago.
5487_2.patch (670 bytes) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by Garry Yao

Description: modified (diff)

Changed 7 years ago by Garry Yao

Attachment: 5487.patch added

comment:2 Changed 7 years ago by Garry Yao

Keywords: Confirmed Review? added
Milestone: CKEditor 3.4
Owner: set to Garry Yao
Status: newassigned

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

There is no need to match the space group. It can be simply added to the (?=) lookahead assertion at the end of the regex.

Changed 7 years ago by Garry Yao

Attachment: 5487_2.patch added

comment:4 Changed 7 years ago by Garry Yao

Keywords: Review? added; Review- removed

comment:5 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.4CKEditor 3.5

comment:6 Changed 7 years ago by Tobiasz Cudnik

Status: reviewreview_passed

comment:7 Changed 7 years ago by Tobiasz Cudnik

Keywords: Confirmed removed
Resolution: fixed
Status: review_passedclosed

Fixed with [5859].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy