Opened 8 years ago

Closed 7 years ago

#5563 closed Bug (fixed)

[FF] 'disableObjectResizing' and 'disableNativeTableHandles' not working

Reported by: Garry Yao Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 3.4
Component: General Version: SVN (CKEditor) - OLD
Keywords: Cc:

Description

Due to changes made at #3593, these two configs stop working since they depends on designMode.

Attachments (3)

5563.patch (2.5 KB) - added by Garry Yao 8 years ago.
disableResize.html (1.1 KB) - added by Alfonso Martínez de Lizarrondo 7 years ago.
Test file
5563_2.patch (1.4 KB) - added by Frederico Caldeira Knabben 7 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 8 years ago by Garry Yao

Keywords: Review? added
Owner: set to Garry Yao
Status: newassigned

Proposing another way to disable object resizing and table handers in both IE and FF.

Changed 8 years ago by Garry Yao

Attachment: 5563.patch added

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.3CKEditor 3.4

comment:3 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review- added; Review? removed

The patch merges both options, so if they are going to do the same, they should be a single option and remove one of them.

Also, we should be sure that there's a ticket filed at Mozilla for this.

comment:4 Changed 7 years ago by Garry Yao

Keywords: Discussion added

Unfortunately there's no way for separating them with the approach proposed by the current patch, is it an option to eventually combine them into one?

comment:5 Changed 7 years ago by Garry Yao

Keywords: HasPatch added; Review- removed
Owner: Garry Yao deleted
Status: assignednew

Changed 7 years ago by Alfonso Martínez de Lizarrondo

Attachment: disableResize.html added

Test file

comment:6 Changed 7 years ago by Alfonso Martínez de Lizarrondo

This file shows that those commands can work with contentEditable, so the problem must be the lots of tricks, time-outs, and whatever that we are using at the moment.

Changed 7 years ago by Frederico Caldeira Knabben

Attachment: 5563_2.patch added

comment:7 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Discussion removed
Owner: set to Frederico Caldeira Knabben
Status: confirmedreview

comment:8 Changed 7 years ago by Sa'ar Zac Elias

Keywords: HasPatch removed
Status: reviewreview_passed

comment:9 Changed 7 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: review_passedclosed

Fixed with [5743].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy