#5583 closed Bug (fixed)
Problem with CKReleaser source version
| Reported by: | Garry Yao | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.3 |
| Component: | Project : CKReleaser | Version: | |
| Keywords: | Confirmed Review+ | Cc: | Wiktor Walc |
Description (last modified by )
Environment
Windows
Reproducing Procedures
- Place the attached bat file under 'test' folder of CKReleaser root along with copying ckreleaser.release file from CKEditor.
- Replace %ckeditor% with the path of a CKEditor local copy.
- Run the script in command line.
- Actual Result:
js: uncaught JavaScript runtime exception: ReferenceError "CKPACKAGER" is not defined.
- Actual Result:
Attachments (3)
Change History (10)
Changed 15 years ago by
| Attachment: | 5583.patch added |
|---|
comment:1 Changed 15 years ago by
| Cc: | Wiktor Walc added |
|---|---|
| Keywords: | Review? added |
| Owner: | set to Garry Yao |
| Status: | new → assigned |
Changed 15 years ago by
| Attachment: | release.bat added |
|---|
comment:2 Changed 15 years ago by
| Description: | modified (diff) |
|---|
comment:3 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
The problem is in accessing CKPackager source files.
Although the fix looks good, I'd prefer to avoid adding files that we don't need to CKReleaser repository (we just need CKPackager source files), so I'd vote for leaving external property intact.
Changed 15 years ago by
| Attachment: | 5583_2.patch added |
|---|
comment:4 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
In the attached patch I've focused on solving _source path issue, I hope it works ;)
comment:5 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:6 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:7 Changed 15 years ago by
| Milestone: | CKEditor 3.4 → CKEditor 3.3 |
|---|
Note: See
TracTickets for help on using
tickets.
Minor justification.