Filter does not allow two 'text' filters

[Garry Yao]

By adding another 'text' type filter to htmldataprocessor breaks the editor output, e.g.

htmlFilter.addRules(
	{
		text : function( text )
		{
			return text;
		}
	});

[Frederico Caldeira Knabben]

The new logic may not always be good. For example, if we have more than one filter and the "currentEntry" is changed by the first filter only, it will not be returned by the callItems function. It will happen only if the last filter changes it.

Other than that, the filter may also change the node type, so subsequent filters to be called will not be good for that node type. Even element or attribute names may be changed, invalidating the next filters. So, to avoid such situation, we should limit this full loop only on text or comment nodes, and only if the filter doesn't change the node type. In other cases, the current behavior must be maintained.

[Garry Yao]

Ticket Test added:
​run OR ​view source.

[Frederico Caldeira Knabben]

• It's ok to append the "type" property to the fragment class, to make the code clearer, avoiding the addition of line 235.

• There is a problem though... a filter may return nothing, which means no change to the current entry. But, at line 272, you're updating the currentEntry with the undefined returned value, which will invalidate the filter in the subsequent calls. That line should be executed only if ret is not undefined.

[Garry Yao]

Replying to fredck:

• It's ok to append the "type" property to the fragment class, to make the code clearer, avoiding the addition of line 235.

We've already have several places that rely on !node.type to detect a fragment node, which will get broken by the suggested change.

• There is a problem though... a filter may return nothing, which means no change to the current entry. But, at line 272, you're updating the currentEntry with the undefined returned value, which will invalidate the filter in the subsequent calls. That line should be executed only if ret is not undefined.

Possibly, the new patch take this into consideration.

[Garry Yao]

Fixed with [5477].